Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "#342 #372 - Try to prevent caching of request" #436

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "#342 #372 - Try to prevent caching of request" #436

wants to merge 1 commit into from

Commits on Jan 25, 2023

  1. Revert "nt1m#342 nt1m#372 - Try to prevent caching of request" 

    This reverts commit a5e38c4.

It's not entirely clear looking at the history, but it seems this was
added to fix a suspected caching problem in nt1m#342. The RSS feed in that
task doesn't exist any more, but looking at the rest of the site at
least as it exists today -- it's not a problem with Firefox/Livemarks,
it's a problem with the site sending broken `Cache-Control` headers!
They are saying their response can be cached for up to a year, which is
obviously wrong for a news site.

But that is a problem with the site, not with Firefox/Livemarks. We
really should not be ignoring *the correct caching headers for every
single other RSS feed on the internet* to solve one broken site. In
particular, since the default refresh interval for Livemarks is 5
minutes, this causes us to force-load all of the RSS feeds every 5
minutes, which tbh is a bit abusive.

This bad behaviour on the part of RSS readers has been called out a few
times, most recently https://rachelbythebay.com/w/2023/01/18/http/ --
let's not be one of the bad ones, especially just to fix a single site
whose RSS feed does not exist any more anyway.
    @jwatzman
    jwatzman committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    04fad8b View commit details
    Browse the repository at this point in the history