-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to mark all items read #312
base: master
Are you sure you want to change the base?
Conversation
This solves #213. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks. Just one small comment.
Happy holidays btw! Sorry it took me a while to get to this.
Suggested nt1m Co-authored-by: Tim Nguyen <[email protected]>
Hey, no problems, given the holidays I wasn't expecting a quick reply. I've added your suggested change. Happy holidays to you too! |
@evilpie wdyt of this PR? It does what it should, but not sure it's going to be expected for users to have their history filled when they click this item |
I have the same concern. Maybe we could make this side-effect more obvious with some different language like "Mark all as read/visited", but I honestly don't like that phrasing myself. Maybe it's fine to add, worst case you can always delete something from your history? |
As a user who has lots of unread items due to losing his history, I agree with this design. Given that currently there is no other way to mark items as read (and I'm not saying there should be), I think it's a good solution. |
Can this be merged pls? |
Since it was inconvenient to have to open each page in order to mark them read I've added a context menu item to mark items as read.
Unfortunately I wasn't able to add all of the corresponding locales entries for it as I do not speak most of those languages. It works fine in English.