Fix closing issues with combobox #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d0729de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
heisand
requested review from
a team,
selbekk,
emildohlenhansen,
cecilmkl and
AnamaP
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When clicking inside the input field, if you do not hit the label, the listbox with suggestions will close. This seems to be due to the
useOutsideClick(When hitting the label, it does not seem that the useOutsideClick has enough time to trigger, because we click via the label first). The popover already seems to have an outsideClick functionality, and withuseOutsideClick, the functionality is duplicated and cancels each other out.It is also not possible to double click inside the input field while the listbox is open, this should be possible to be able to copy written input.
Illustrations
Issue illustrated in the first part of this recording.
Screen_Recording_2023-07-18_at_12.39.01.mov
Solution
Remove the
useOutsideClickhook.Add the
isNonModalprop to the popover to make double clicking inside the input field possible.