Fix an issue with the combobox listbox closing on keyUp #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heisand
requested review from
a team,
selbekk,
emildohlenhansen,
cecilmkl and
AnamaP
and removed request for
a team
🦋 Changeset detectedLatest commit: bcba3d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
heisand
changed the title
|
Removing type information fixes a behavioral bug? I don't get how that's possible. But hey, if we don't need it, i'm all for it. |
I agree about the oddity of that, and now it does not work again.. but some of my other changes locally fixed it, so I have to double check what actually fixed it.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When clicking inside the input field, if you do not hit the lable, the listbox with suggestions will close. Somehow it seems that an onKeyUp triggers that, but when hitting the lable it seems that the key up does not have enough time to do so because we click via the label first.. or something like that.
Illustrations
Illustrated in the first part of this recording.
Screen_Recording_2023-07-18_at_12.39.01.mov
Solution
The reason this happens is somehow that the inputRef specifically has type HTMLInputElement here. I believe that we really do not need to specify the type in this case (and now the listbox stays open when it should).