Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use as="a" for external links in actionLink #1282

Merged
merged 1 commit into from
Oct 1, 2024
Merged

use as="a" for external links in actionLink #1282

merged 1 commit into from
Oct 1, 2024

Conversation

Cmoen11
Copy link
Member

@Cmoen11 Cmoen11 commented Oct 1, 2024

Background

"as" wasn't defined for external link, so the "a" was defined as a div instead.

Solution

added as tag

@Cmoen11 Cmoen11 requested review from ithen15 and a team as code owners October 1, 2024 13:26
@Cmoen11 Cmoen11 requested review from leiferikbjorkli, cibietici, alicemacl, MTeresita, mcklien and Siljeelisestrm and removed request for a team October 1, 2024 13:26
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024

⚠️ No Changeset found

Latest commit: 3f7c5d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Cmoen11 Cmoen11 changed the title add proper anchor tag for external links use as="a" for external links in actionLink Oct 1, 2024
@Cmoen11 Cmoen11 merged commit 01164f8 into main Oct 1, 2024
3 checks passed
@Cmoen11 Cmoen11 deleted the fix-external-links-for-action-link branch October 1, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicemacl alicemacl alicemacl approved these changes

@ithen15 ithen15 Awaiting requested review from ithen15 ithen15 is a code owner

@leiferikbjorkli leiferikbjorkli Awaiting requested review from leiferikbjorkli leiferikbjorkli is a code owner automatically assigned from nsbno/team-kanaler

@cibietici cibietici Awaiting requested review from cibietici cibietici is a code owner automatically assigned from nsbno/team-kanaler

@MTeresita MTeresita Awaiting requested review from MTeresita MTeresita is a code owner automatically assigned from nsbno/team-kanaler

@mcklien mcklien Awaiting requested review from mcklien mcklien is a code owner automatically assigned from nsbno/team-kanaler

@Siljeelisestrm Siljeelisestrm Awaiting requested review from Siljeelisestrm Siljeelisestrm is a code owner automatically assigned from nsbno/team-kanaler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cmoen11 @alicemacl