Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the option to display optional phone number #1250

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

mar2n
Copy link
Contributor

@mar2n mar2n commented Aug 26, 2024

Background

The phoneNumberInput at the Swedish payment page are optional for not-main travellers, but currently not visible for the user that it is

Solution

Add prop to be able to show that the field is optional

UU checks

  • It is possible to use the keyboard to reach your changes
  • It is possible to enlarge the text 400% without losing functionality
  • It works on both mobile and desktop
  • It works in both Chrome, Safari and Firefox
  • It works with VoiceOver
  • There are no errors in aXe / SiteImprove-plugins / Wave
  • Sanity documentation has been / will be updated (if neccessary)
  • Documentation version has been bumped (package.json in docs)

Note: To trigger pipeline for the documentation site (spor.vy.no) you need to bump the version.

How to test

Technical change. No change on current inputs, but able to add the prop isOptional={true} to see the new text

Screenshots

Before After
image image
image

@mar2n mar2n requested a review from a team August 26, 2024 10:41
@mar2n mar2n requested review from johnolos, ithen15 and a team as code owners August 26, 2024 10:41
@mar2n mar2n requested review from Cmoen11, leiferikbjorkli, cibietici, alicemacl, MTeresita and mcklien and removed request for a team August 26, 2024 10:41
Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: 06f8d91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vygruppen/spor-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mar2n
Copy link
Contributor Author

mar2n commented Aug 26, 2024

Kjørte npx changeset. Er det riktig og nødvendig?
Oppdaterte ikke versjon i package.json, burde det være med?

Copy link
Contributor

@alicemacl alicemacl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liten endring i changeset, ser ellers bra ut.

Ja, man må ha changeset hver eneste gang man endrer en pakke.

Package må bare oppdateres dersom man ikke endrer en pakke. Skal gjøre det mer klart i changeset.

Les mer om changeset, hvilket du skal velge og hvordan det fungerer her:

https://spor.vy.no/guides/releasing-new-versions

.changeset/chilled-cheetahs-applaud.md Outdated Show resolved Hide resolved
@mar2n mar2n merged commit ad91d4f into main Aug 26, 2024
2 checks passed
@mar2n mar2n deleted the phonenumberinput-optional branch August 26, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants