Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to common-services #1207

Merged
merged 41 commits into from
Sep 6, 2024
Merged

Migrate to common-services #1207

merged 41 commits into from
Sep 6, 2024

Conversation

faergestad
Copy link
Contributor

@faergestad faergestad commented Jun 27, 2024 •
edited
Loading

Background

Spor is currently running in one of our old AWS accounts

Solution

Migrate spor to new accounts, and update config/pipelines accordingly

@faergestad faergestad requested review from johnolos, ithen15 and a team as code owners June 27, 2024 13:34
@faergestad faergestad requested review from Cmoen11, leiferikbjorkli, cibietici, alicemacl, MTeresita and mcklien and removed request for a team June 27, 2024 13:34
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 33cdfd7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@faergestad faergestad marked this pull request as draft June 28, 2024 10:26
@faergestad faergestad marked this pull request as ready for review July 31, 2024 12:15
@faergestad
Copy link
Contributor Author

This will not be merged before we are ready to change the dns records to point to the new running instance

MikaelSvanasbakken
MikaelSvanasbakken approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@MikaelSvanasbakken MikaelSvanasbakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

alicemacl
alicemacl approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@alicemacl alicemacl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@faergestad faergestad merged commit 11e6aac into main Sep 6, 2024
3 checks passed
@faergestad faergestad deleted the migrate-to-common-services branch September 6, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikaelSvanasbakken MikaelSvanasbakken MikaelSvanasbakken approved these changes

@alicemacl alicemacl alicemacl approved these changes

@johnolos johnolos Awaiting requested review from johnolos

@ithen15 ithen15 Awaiting requested review from ithen15 ithen15 is a code owner

@Cmoen11 Cmoen11 Awaiting requested review from Cmoen11 Cmoen11 is a code owner automatically assigned from nsbno/team-kanaler

@leiferikbjorkli leiferikbjorkli Awaiting requested review from leiferikbjorkli leiferikbjorkli is a code owner automatically assigned from nsbno/team-kanaler

@cibietici cibietici Awaiting requested review from cibietici cibietici is a code owner automatically assigned from nsbno/team-kanaler

@MTeresita MTeresita Awaiting requested review from MTeresita MTeresita is a code owner automatically assigned from nsbno/team-kanaler

@mcklien mcklien Awaiting requested review from mcklien mcklien is a code owner automatically assigned from nsbno/team-kanaler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faergestad @MikaelSvanasbakken @alicemacl