[nrf noup] Sysbuild support for MCUboot crypto backend selection #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit adds support for selecting MCUboot crypto backend, when building with sysbuild. This currently adds two options: - SB_CONFIG_BOOT_CRYPTO_LIBRARY_DEFAULT -- which keeps current behaviour where a library is selected depending on preferred signature method - SB_CONFIG_BOOT_CRYPTO_LIBRARY_PSA -- enforces usage of PSA, regardless of signature algorithm; the option currently supports the ED25519 only. Signed-off-by: Dominik Ermel <[email protected]>
nordicjm
requested changes
Oct 2, 2024
| @@ -55,6 +55,35 @@ config BOOT_SIGNATURE_TYPE_ED25519 | |||
|
|
|||
| endchoice | |||
|
|
|||
| choice BOOT_CRYPTO_LIBRARY | |||
There was a problem hiding this comment.
this goes in sdk-nrf under sysbuild/Kconfig.sysbuild
nordicjm
reviewed
Oct 2, 2024
Comment on lines
+71
to
+83
| if BOOT_CRYPTO_LIBRARY_PSA | ||
|
|
||
| config MBEDTLS | ||
| bool | ||
| default n | ||
|
|
||
| config MBEDTLS_PSA_CRYPTO_C | ||
| bool | ||
| default y | ||
|
|
||
| config NRF_SECURITY | ||
| bool | ||
| default y |
There was a problem hiding this comment.
this does not do anything to the target image, these can go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit adds support for selecting MCUboot crypto backend, when building with sysbuild.
This currently adds two options: