Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: basic: blinky: add mbox backend for eGPIO #1910

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

jaz1-nordic
Copy link
Contributor

@jaz1-nordic jaz1-nordic commented Jul 24, 2024

No description provided.

Copy link
Contributor

@nordic-piks nordic-piks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please allow verification via console logs for blinky sample.

@jaz1-nordic jaz1-nordic force-pushed the mbox-backend-in-eGPIO branch 4 times, most recently from 4d49986 to 8072715 Compare September 13, 2024 06:04
magp-nordic pushed a commit to magp-nordic/sdk-zephyr that referenced this pull request Sep 13, 2024
Add yaml configurations to enable eGPIO tests with sysbuild
and different backends.

Cherry-picked from nrfconnect#1910 PR.

Signed-off-by: Jakub Zymelka <[email protected]>
@jaz1-nordic jaz1-nordic force-pushed the mbox-backend-in-eGPIO branch 2 times, most recently from 405d4e1 to dfd484c Compare September 16, 2024 14:25
Copy link
Contributor

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this a noup instead of a fromlist?

@masz-nordic
Copy link
Contributor

Because this requires eGPIO, which is only present in NCS.

Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be carrying these sort of patches downstream. They do not seem to follow best practices, and will likely keep increasing upmerge times. Why isn't this developed directly upstream?

@carlescufi
Copy link
Contributor

Please use the alt-root instead: https://github.com/nrfconnect/sdk-nrf/tree/main/scripts/twister/alt/zephyr
Check with @PerMac for additional info about the twister alt-root we have in Zephyr.

jaz1-nordic and others added 2 commits October 1, 2024 11:20
Add overlay for nrf54l15dk to enable eGPIO tests.

Signed-off-by: Jakub Zymelka <[email protected]>
…ion handling

Fixes an issue with HWMv2 boards whereby the specified board
revision was not applied at the correct place, which would cause
the target image to fail configuration

Fixes #79208

Upstream PR: zephyrproject-rtos/zephyr#79209

Signed-off-by: Jamie McCrae <[email protected]>
@nordicjm nordicjm merged commit 8005d4e into nrfconnect:main Oct 2, 2024
20 checks passed
@jaz1-nordic jaz1-nordic deleted the mbox-backend-in-eGPIO branch October 2, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants