[nrf noup] platform: nordic_nrf: add support for nrf54l15dk #170
+23
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove support for `nrf54l15pdk` at the same time. Occurences of `NRF54L15_ENGA_XXAA` are replaced by `NRF54L15_XXAA`. Files from the `nrf54l15dk_nrf54l15_cpuapp` directory that are unused are deleted. One of them, `tfm_peripherals_config.h`, even had a blatant syntax issue (`#endiff`). Signed-off-by: Tomi Fontanilles <[email protected]>
Vge0rge
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Hm, this file and the CMakeLists are required to build the tfm tests AFAIK. Did you manage to build the PSA arch tests and the regression tests with this PR for the new target?
There was a problem hiding this comment.
Yes. Those two CMake files manifestly weren't needed.
There was a problem hiding this comment.
The tests directory inside of this is required, though. It's installed by sdk-nrf CMake logic during build. (Not sure if the files in there are actually useful, haven't dug into that.)
Vge0rge
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove support for
nrf54l15pdkat the same time. Occurences ofNRF54L15_ENGA_XXAAare replaced byNRF54L15_XXAA.Files from the
nrf54l15dk_nrf54l15_cpuappdirectory that are unused are deleted.One of them,
tfm_peripherals_config.h, even had a blatant syntax issue (#endiff).