Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: lte_lc: deprecate LTE_LC_ON_CFUN #17589

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eivindj-nordic
Copy link
Contributor

Deprecate LTE_LC_ON_CFUN. The application should instead use the NRF_MODEM_LIB_ON_CFUN macro.

@eivindj-nordic eivindj-nordic added this to the 2.8.0 milestone Oct 2, 2024
@eivindj-nordic eivindj-nordic self-assigned this Oct 2, 2024
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Oct 2, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 2, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: 80ca74befd7252b8dc3b1c16fe4758bf3f35e512

more details

sdk-nrf:

PR head: 80ca74befd7252b8dc3b1c16fe4758bf3f35e512
merge base: ada3cea9ff7ea911ec269069fb95d97d38386c6a
target head (main): ca2219e2b85e60fd6e9d948f0f059eeb97dd27a3
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (10)
doc
│  ├── nrf
│  │  ├── libraries
│  │  │  ├── modem
│  │  │  │  ├── lte_lc.rst
│  │  │  │  ├── nrf_modem_lib
│  │  │  │  │  │ nrf_modem_lib_wrapper.rst
│  │  ├── releases_and_maturity
│  │  │  ├── migration
│  │  │  │  │ migration_guide_2.8.rst
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
include
│  ├── modem
│  │  ├── lte_lc.h
│  │  │ nrf_modem_lib.h
lib
│  ├── sms
│  │  │ sms.c
samples
│  ├── cellular
│  │  ├── modem_callbacks
│  │  │  │ README.rst
│  │  ├── modem_trace_backend
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── modem_trace_flash
│  │  │  ├── src
│  │  │  │  │ main.c

Outputs:

Toolchain

Version: 9583beca34
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:9583beca34_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
    • sdk-nrf test count: 305
  • ❌ Integration tests
    • ❌ test-fw-nrfconnect-nrf-iot_cloud
    • ❌ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ❌ test-fw-nrfconnect-nrf-iot_samples
    • ❌ test-fw-nrfconnect-nrf-iot_lwm2m
    • ❌ test-fw-nrfconnect-nrf-iot_mosh
    • ❌ test-fw-nrfconnect-nrf-iot_positioning
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@peknis peknis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor nit.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@eivindj-nordic eivindj-nordic force-pushed the deprecate_lte_lc_on_cfun branch 2 times, most recently from 11aff74 to 6d50df1 Compare October 2, 2024 08:59
Copy link
Contributor

@trantanen trantanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK in general but please fix the CI, which has dozens of failures.

Deprecate LTE_LC_ON_CFUN. The application should instead use the
NRF_MODEM_LIB_ON_CFUN macro.

Signed-off-by: Eivind Jølsgard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants