Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: matter: Enable DFU over BLE SMP for nRF54H20 #17525

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

samples: matter: Enable DFU over BLE SMP for nRF54H20 #17525

wants to merge 1 commit into from
+232 −107

Conversation

ArekBalysNordic
Copy link
Contributor

  • Works with external flash utilizing companion image.
  • Uses SUIT CACHE RW to store app & rad images into the cache partition.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 27, 2024
@NordicBuilder
Copy link
Contributor

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@89eb37b (master) nrfconnect/sdk-connectedhomeip#483 nrfconnect/sdk-connectedhomeip#483/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 27, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 39768e66fb6e512c20c30476f5164938e6ca4308
matter: PR head: 8587b30209ba28da0439023fc143c1a27deaaac7

more details

sdk-nrf:

PR head: 39768e66fb6e512c20c30476f5164938e6ca4308
merge base: ca2219e2b85e60fd6e9d948f0f059eeb97dd27a3
target head (main): ca2219e2b85e60fd6e9d948f0f059eeb97dd27a3
Diff

matter:

PR head: 8587b30209ba28da0439023fc143c1a27deaaac7
merge base: 89eb37b47ca8e4b9d309c431bde30bdb19d07577
target head (master): 89eb37b47ca8e4b9d309c431bde30bdb19d07577
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (16) 
config
│  ├── suit
│  │  ├── templates
│  │  │  ├── nrf54h20
│  │  │  │  ├── matter
│  │  │  │  │  ├── v1
│  │  │  │  │  │  ├── app_envelope.yaml.jinja2
│  │  │  │  │  │  ├── rad_envelope.yaml.jinja2
│  │  │  │  │  │  │ root_with_binary_nordic_top.yaml.jinja2
modules
│  ├── lib
│  │  ├── matter
│  │  │  ├── config
│  │  │  │  ├── nrfconnect
│  │  │  │  │  ├── chip-module
│  │  │  │  │  │  │ Kconfig
samples
│  ├── matter
│  │  ├── common
│  │  │  ├── dts
│  │  │  │  ├── nrf54h20
│  │  │  │  │  ├── nrf54h20_cpuapp_memory_map.dtsi
│  │  │  │  │  ├── nrf54h20_cpuapp_peripherals.dtsi
│  │  │  │  │  │ nrf54h20_flash_companion.dtsi
│  │  ├── lock
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp.conf
│  │  │  ├── sysbuild
│  │  │  │  ├── flash_companion.overlay
│  │  │  │  ├── ipc_radio
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54h20dk_nrf54h20_cpurad.conf
│  │  ├── template
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── boards
│  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp.conf
│  │  │  ├── sysbuild
│  │  │  │  ├── flash_companion.overlay
│  │  │  │  ├── ipc_radio
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54h20dk_nrf54h20_cpurad.conf
west.yml

Outputs:

Toolchain

Version: 9583beca34
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:9583beca34_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 128
  • ❌ Integration tests
    • ❌ test-fw-nrfconnect-chip
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@ArekBalysNordic ArekBalysNordic force-pushed the nrf54h20_smp_dfu branch 2 times, most recently from 5af2a13 to b0a8b09 Compare September 27, 2024 12:22
kkasperczyk-no
kkasperczyk-no reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@kkasperczyk-no kkasperczyk-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to enable DFU over SMP for Matter bridge as well?

@ArekBalysNordic
Copy link
Contributor Author

Would it make sense to enable DFU over SMP for Matter bridge as well?

I guess it is not applicable there until the dfu_partition is so big. We need to wait for the new approach to enable it for Matter Bridge.

ahasztag
ahasztag approved these changes Oct 2, 2024
View reviewed changes
config/suit/templates/nrf54h20/matter/v1/rad_envelope.yaml.jinja2
@@ -26,6 +26,8 @@ SUIT_Envelope_Tagged:
- {{ radio['dt'].chosen_nodes['zephyr,code-partition'].regs[0].size }}
- - CAND_IMG
- 0
- - CACHE_POOL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this could be wrapped in
{%- if 'CONFIG_SUIT_DFU_CACHE_EXTRACT_IMAGE' not in radio['config'] or radio['config']['CONFIG_SUIT_DFU_CACHE_EXTRACT_IMAGE'] == '' %}

but this has to be aligned anyway in default SUIT templates, so I will probably do this myself

@ArekBalysNordic
samples: matter: Enable DFU over BLE SMP for nRF54H20
39768e6 
- Works with external flash utilizing companion image.
- Uses SUIT CACHE RW to store app & rad images into the cache
partition.

Signed-off-by: Arkadiusz Balys <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchy tomchy tomchy approved these changes

@nordicjm nordicjm nordicjm approved these changes

@kkasperczyk-no kkasperczyk-no kkasperczyk-no approved these changes

@ahasztag ahasztag ahasztag approved these changes

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-matter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ArekBalysNordic @NordicBuilder @tomchy @nordicjm @kkasperczyk-no @ahasztag