sysbuild: Add compression options for MCUboot #17330

nordicjm · 2024-09-16T12:36:12Z

manifest: Update sdk-mcuboot

Pulls in changes for image decompression support



sysbuild: Add compression options for MCUboot

Adds an option which will enable compressed image support in
MCUboot



tests: nrf_compress: decompression: Add mcuboot_update test

Adds a test which ensures compressed update image support works
in MCUbot

NordicBuilder · 2024-09-16T12:36:43Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
mcuboot	nrfconnect/sdk-mcuboot@`763edd6`	nrfconnect/sdk-mcuboot@`3909498`	nrfconnect/[email protected]
zephyr	nrfconnect/sdk-zephyr@`8005d4e`	nrfconnect/sdk-zephyr@`3f835fe` (main)	nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2024-09-16T12:50:23Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 19

Inputs:

Sources:

sdk-nrf: PR head: 02ff74376488e1949cfcb2e1a89246eb76ee25db
mcuboot: PR head: 3909498f76f91c5b8a95ea38d4c7084a03459a55
zephyr: PR head: 3f835fec4f01a10a055c23760f6a0f40aa77eaab

more details

sdk-nrf:

PR head: 02ff74376488e1949cfcb2e1a89246eb76ee25db
merge base: c0ec7662c35b545b96759e3cf9e50ba0216b3b82
target head (main): ca2219e2b85e60fd6e9d948f0f059eeb97dd27a3
Diff

mcuboot:

PR head: 3909498f76f91c5b8a95ea38d4c7084a03459a55
merge base: 763edd653b1b9a5efd643221333e9ea16767da11
Diff

zephyr:

PR head: 3f835fec4f01a10a055c23760f6a0f40aa77eaab
merge base: 8005d4e87b9bcba25f441a51f4f5d29b541022b9
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (36)

bootloader
│  ├── mcuboot
│  │  ├── boot
│  │  │  ├── zephyr
│  │  │  │  │ Kconfig
│  │  ├── scripts
│  │  │  ├── imgtool
│  │  │  │  ├── image.py
│  │  │  │  │ main.py
cmake
│  ├── sysbuild
│  │  │ image_signing.cmake
samples
│  ├── nrf_compress
│  │  ├── mcuboot_update
│  │  │  ├── CMakeLists.txt
│  │  │  ├── prj.conf
│  │  │  ├── src
│  │  │  │  │ hook.c
│  │  │  ├── sysbuild.conf
│  │  │  ├── sysbuild
│  │  │  │  │ mcuboot.conf
│  │  │  │ testcase.yaml
subsys
│  ├── bootloader
│  │  │ Kconfig
│  ├── partition_manager
│  │  │ Kconfig
sysbuild
│  ├── CMakeLists.txt
│  │ Kconfig.mcuboot
tests
│  ├── subsys
│  │  ├── nrf_compress
│  │  │  ├── decompression
│  │  │  │  ├── mcuboot_update
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── Kconfig
│  │  │  │  │  ├── app.overlay
│  │  │  │  │  ├── compressed_app
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ main.c
│  │  │  │  │  ├── modified_signing.cmake
│  │  │  │  │  ├── pm_static_nrf52840dk_nrf52840.yml
│  │  │  │  │  ├── pm_static_nrf5340dk_nrf5340_cpuapp.yml
│  │  │  │  │  ├── pm_static_nrf54l15dk_nrf54l15_cpuapp.yml
│  │  │  │  │  ├── prj.conf
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  │  │  │  ├── sysbuild.cmake
│  │  │  │  │  ├── sysbuild.conf
│  │  │  │  │  ├── sysbuild
│  │  │  │  │  │  ├── mcuboot
│  │  │  │  │  │  │  ├── app.overlay
│  │  │  │  │  │  │  ├── boards
│  │  │  │  │  │  │  │  ├── nrf52840dk_nrf52840.conf
│  │  │  │  │  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │  │  │  │  │  │ prj.conf
│  │  │  │  │  │ testcase.yaml
west.yml
zephyr
│  ├── include
│  │  ├── zephyr
│  │  │  ├── arch
│  │  │  │  ├── arm
│  │  │  │  │  ├── cortex_m
│  │  │  │  │  │  ├── scripts
│  │  │  │  │  │  │  │ linker.ld

Outputs:

Toolchain

Version: 9583beca34
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:9583beca34_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
❌ Build twister
❌ Integration tests
- ❌ test-sdk-audio
- ❌ desktop52_verification
- ❌ test-fw-nrfconnect-boot
- ❌ test-fw-nrfconnect-apps
- ❌ test_ble_nrf_config
- ❌ test-fw-nrfconnect-ble_mesh
- ❌ test-fw-nrfconnect-ble_samples
- ❌ test-fw-nrfconnect-chip
- ❌ test-fw-nrfconnect-nfc
- ❌ test-fw-nrfconnect-nrf-iot_cloud
- ❌ test-fw-nrfconnect-nrf-iot_libmodem-nrf
- ❌ test-fw-nrfconnect-nrf-iot_serial_lte_modem
- ❌ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- ❌ test-fw-nrfconnect-nrf-iot_samples
- ❌ test-fw-nrfconnect-nrf-iot_lwm2m
- ❌ doc-internal
- ❌ test-fw-nrfconnect-nrf-iot_thingy91
- ❌ test-fw-nrfconnect-nrf_crypto
- ❌ test-fw-nrfconnect-proprietary_esb
- ❌ test-fw-nrfconnect-rpc
- ❌ test-fw-nrfconnect-rs
- ❌ test-fw-nrfconnect-fem
- ❌ test-fw-nrfconnect-tfm
- ❌ test-fw-nrfconnect-thread
- ❌ test-fw-nrfconnect-zigbee
- ❌ test-sdk-find-my
- ❌ test-fw-nrfconnect-nrf-iot_mosh
- ❌ test-fw-nrfconnect-nrf-iot_positioning
- ❌ test-sdk-sidewalk
- ❌ test-sdk-wifi
- ❌ test-low-level
- ❌ test-fw-nrfconnect-nrf-iot_nrf_provisioning
- ❌ test-sdk-pmic-samples
- ❌ test-sdk-mcuboot
- ❌ test-sdk-dfu
- ❌ test-fw-nrfconnect-ps
- ❌ test-secdom-samples-public
- ⚠️ test-fw-nrfconnect-fw-update

Note: This message is automatically posted and updated by the CI

NordicBuilder · 2024-09-16T12:59:55Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

nvlsianpu

just a few nits. Now I see why you need intel-hex output from imgtool.py

nvlsianpu · 2024-09-25T06:30:19Z

samples/nrf_compress/mcuboot_update/src/main.c

not a main content of this sample in this file - expect main(). rename?

nvlsianpu · 2024-09-25T06:32:49Z

samples/nrf_compress/mcuboot_update/src/main.c

+#endif
+
+static struct mgmt_callback img_slot_callback;
+


comment in the code for explaining what is it doing would be helpful once someone will look at this in few months.

nvlsianpu · 2024-09-25T06:33:47Z

samples/nrf_compress/mcuboot_update/src/main.c

+	return 0;
+}
+
+SYS_INIT(setup_something, APPLICATION, 0);


what does this SYS_INIT?

nvlsianpu · 2024-09-25T06:39:53Z

...mpress/decompression/mcuboot_update/sysbuild/mcuboot/boards/nrf54l15pdk_nrf54l15_cpuapp.conf

+CONFIG_BOOT_MAX_IMG_SECTORS=256
+
+# Ensure that the qspi driver is disabled by default
+CONFIG_NORDIC_QSPI_NOR=n


Suggested change

CONFIG_NORDIC_QSPI_NOR=n

CONFIG_NORDIC_SPI_NOR=n

nRF54l15 hasn't QSPI.

Adds an option that will utilise the whole SRAM size as specified by a single image, and enables it for nrf54l15 when using decompression in MCUboot Signed-off-by: Jamie McCrae <[email protected]>

Pulls in changes for image decompression support and PM SRAM using the Kconfig value Signed-off-by: Jamie McCrae <[email protected]>

Adds an option which will enable compressed image support in MCUboot Signed-off-by: Jamie McCrae <[email protected]>

Adds a test which ensures compressed update image support works in MCUbot Signed-off-by: Jamie McCrae <[email protected]>

Adds a sample which shows usage of compressed image updates Signed-off-by: Jamie McCrae <[email protected]>

github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 16, 2024

NordicBuilder added manifest-mcuboot DNM labels Sep 16, 2024

nordicjm force-pushed the mcubootcompresstest branch 5 times, most recently from 2b69b1a to 9df875d Compare September 20, 2024 12:11

nordicjm marked this pull request as ready for review September 20, 2024 12:11

nordicjm requested review from a team as code owners September 20, 2024 12:11

nordicjm force-pushed the mcubootcompresstest branch 3 times, most recently from 861cdf9 to 1481c87 Compare September 24, 2024 15:03

nvlsianpu requested changes Sep 25, 2024

View reviewed changes

nordicjm force-pushed the mcubootcompresstest branch 7 times, most recently from 74087b4 to 477181a Compare October 2, 2024 10:55

NordicBuilder added the manifest-zephyr label Oct 2, 2024

nordicjm force-pushed the mcubootcompresstest branch from 477181a to 2ad8413 Compare October 2, 2024 13:07

nvlsianpu approved these changes Oct 3, 2024

View reviewed changes

partition_manager: kconfig: Add option to use all SRAM in PM

e65fe5f

Adds an option that will utilise the whole SRAM size as specified by a single image, and enables it for nrf54l15 when using decompression in MCUboot Signed-off-by: Jamie McCrae <[email protected]>

nordicjm force-pushed the mcubootcompresstest branch from 2ad8413 to d0a03a9 Compare October 4, 2024 07:18

nordicjm added 4 commits October 4, 2024 09:57

manifest: Update sdk-mcuboot and sdk-zephyr

02c4a8d

Pulls in changes for image decompression support and PM SRAM using the Kconfig value Signed-off-by: Jamie McCrae <[email protected]>

sysbuild: Add compression options for MCUboot

22844b6

Adds an option which will enable compressed image support in MCUboot Signed-off-by: Jamie McCrae <[email protected]>

tests: nrf_compress: decompression: Add mcuboot_update test

843ffe6

Adds a test which ensures compressed update image support works in MCUbot Signed-off-by: Jamie McCrae <[email protected]>

samples: nrf_compress: Add mcuboot_update sample

02ff743

Adds a sample which shows usage of compressed image updates Signed-off-by: Jamie McCrae <[email protected]>

nordicjm force-pushed the mcubootcompresstest branch from d0a03a9 to 02ff743 Compare October 4, 2024 08:59

NordicBuilder removed the DNM label Oct 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sysbuild: Add compression options for MCUboot #17330

sysbuild: Add compression options for MCUboot #17330

nordicjm commented Sep 16, 2024

NordicBuilder commented Sep 16, 2024 •

edited

Loading

NordicBuilder commented Sep 16, 2024 •

edited

Loading

NordicBuilder commented Sep 16, 2024

nvlsianpu left a comment

nvlsianpu Sep 25, 2024

nvlsianpu Sep 25, 2024

nvlsianpu Sep 25, 2024

nvlsianpu Sep 25, 2024

sysbuild: Add compression options for MCUboot #17330

Are you sure you want to change the base?

sysbuild: Add compression options for MCUboot #17330

Conversation

nordicjm commented Sep 16, 2024

NordicBuilder commented Sep 16, 2024 • edited Loading

NordicBuilder commented Sep 16, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

NordicBuilder commented Sep 16, 2024

nvlsianpu left a comment

Choose a reason for hiding this comment

nvlsianpu Sep 25, 2024

Choose a reason for hiding this comment

nvlsianpu Sep 25, 2024

Choose a reason for hiding this comment

nvlsianpu Sep 25, 2024

Choose a reason for hiding this comment

nvlsianpu Sep 25, 2024

Choose a reason for hiding this comment

NordicBuilder commented Sep 16, 2024 •

edited

Loading

NordicBuilder commented Sep 16, 2024 •

edited

Loading