-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: Use pip-compile-cross-platform #17307
base: main
Are you sure you want to change the base?
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 5ef630271fb41c5b06b5be68a4ab87b264755053 more detailssdk-nrf:
Github labels
List of changed files detected by CI (3)
Outputs:ToolchainVersion: 0c9ca97121 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
I understand the issue, but is this the only way around that problem ?
|
3e7ad65
to
179908f
Compare
pip-compile does not support generating one output file for different environments (operating systems) If we run it on Linux, it drops all packages which available only onl Windows (like windows-curses). pip-compile-cross-platform passes conditional markers from input files to output one. Signed-off-by: Jan Gałda <[email protected]>
179908f
to
5ef6302
Compare
# | ||
# pip-compile --allow-unsafe --annotation-style=line --output-file=nrf/scripts/requirements-fixed.txt --strip-extras bootloader/mcuboot/scripts/requirements.txt nrf/scripts/requirements-ci.txt nrf/scripts/requirements-extra.txt nrf/scripts/requirements.txt zephyr/scripts/requirements.txt | ||
# pip-compile-cross-platform bootloader/mcuboot/scripts/requirements.txt nrf/scripts/requirements-ci.txt nrf/scripts/requirements-extra.txt nrf/scripts/requirements.txt zephyr/scripts/requirements.txt --output-file nrf/scripts/requirements-fixed.txt --min-python-version 3.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we use "--min-python-version 3.12"
pip-compile does not support generating one output file for different environments (operating systems) If we run it on Linux, it drops all packages which available only onl Windows (like windows-curses).
pip-compile-cross-platform passes conditional markers from input files to output one.