childimage/NSIB: Remove non-functional environmental key support #17088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 13f07f07ca0c6473537c6c5964e458e5a9b3404a more detailssdk-nrf:
Github labels
List of changed files detected by CI (3)Outputs:ToolchainVersion: 2aae60c2f9 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
|
CI passed after re-run. |
annwoj
reviewed
Aug 30, 2024
| @@ -45,6 +45,12 @@ Build and configuration system | |||
| .. note:: | |||
| This has security implications and may allow secrets to be leaked to the non-secure application in RAM. | |||
|
|
|||
| * Removed non-working support for setting the NSIB signing key using either environmental or command line variable ``SB_SIGNING_KEY_FILE`` along with child_image. | |||
There was a problem hiding this comment.
Suggested change
| * Removed non-working support for setting the NSIB signing key using either environmental or command line variable ``SB_SIGNING_KEY_FILE`` along with child_image. | |
| * Removed the non-working support for configuring the NSIB signing key through the environmental or command line variable (``SB_SIGNING_KEY_FILE``), along with child image. |
Comment on lines
50
to
51
| ..note:: | ||
| This never been working. Use any Kconfig method for configuring the signing key. |
There was a problem hiding this comment.
Suggested change
| ..note:: | |
| This never been working. Use any Kconfig method for configuring the signing key. | |
| ..note:: | |
| This feature has never been functional. | |
| To configure the signing key, use any available Kconfig method. |
nvlsianpu
force-pushed
the
drop_env_signing_key_childimage
branch
from
2f238ba
to
1a3a284
Compare
Removes non-workable possibility for configuring signing key using either environmental or command-line variable (SB_SIGNING_KEY_FILE). This has never worked. ref.: NCSDK-28124 Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
force-pushed
the
drop_env_signing_key_childimage
branch
from
1a3a284
to
d52dc07
Compare
Added note on removal of the configuration method. Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
force-pushed
the
drop_env_signing_key_childimage
branch
from
d52dc07
to
13f07f0
Compare
annwoj
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes non-workable possibility for configuring signing key using
either environmental or command-line variable (SB_SIGNING_KEY_FILE).
This has never worked.
ref.: NCSDK-28124
similar change was done for the sysbuild (#16154)