v2.6: Backport latest fixes #16934
Merged
v2.6: Backport latest fixes #16934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[SHEL-2947] QoS null frame based legacy power save support. Signed-off-by: Ajay Parida <[email protected]>
[SHEL-2947] Changing naming of power save mode to mechanism(Text change). Signed-off-by: Ajay Parida <[email protected]>
FMAC relies on these callbacks to perform a RPU recovery i.e., coldboot the device in a clean way, this is achieved by performing an interface down and then up, this properly cleans up the driver, performs a cold boot and either through NET_IF events (for scan only) or WPA_S events (for full Wi-Fi) notifies the applications. Implements SHEL-2726. Signed-off-by: Chaitanya Tata <[email protected]>
In case we get multiple watchdog timers in succession, we need to sequentialize the recovery. Implements SHEL-2726. Signed-off-by: Chaitanya Tata <[email protected]>
In some scenarios esp. while debugging nRF70, this feature should be disabled, so, provide a feature flag and mark it as experimental. Implements SHEL-2726. Signed-off-by: Chaitanya Tata <[email protected]>
This delay ensures that the applications have enough time to perform any cleanup and be prepared once the RPU is powered on again. Implements SHEL-2726. Signed-off-by: Chaitanya Tata <[email protected]>
This is necessary as recovery involves calling down and up in a rapid succession. Implements SHEL-2726. Signed-off-by: Chaitanya Tata <[email protected]>
This helps us verify the recovery mechanism. Implements SHEL-2726. Signed-off-by: Chaitanya Tata <[email protected]>
During watchdog (or any) interrupt processing, RPU accesses are being made and they assert the wakeup_now flag this causes RPU recovery to not trigger. New false or true recovery detection algo: Check the time difference b/w last de-assert and assert, and if it exceeds minimum time needed for RPU to enter sleep, then not the timestamp. This timestamp will be used to compare when a watchdog interrupt is received and see if during the last window if host has given a chance for RPU to attempt sleep, if yes, then attempt recovery else ignore watchdog. Also, add a Kconfig for the 10s active time that triggers recovery, this needs to be passed to the FW (once we have enough patch memory). Also, add a Kconfig for the minimum time needed for RPU to attempt sleep in positive case. Also, add a new _ms API for time stamp fetch, this is to avoid precision loss when converting to and from ms to us and also makes code readable by avoiding *1000 and /1000. Signed-off-by: Chaitanya Tata <[email protected]>
In case RPU is stuck and need a recovery, the failures in interface down should be ignored as they are expected and we should proceed with device removal that in turn removes power to the RPU. TODO: This works for single VIF, but needs more thought for multi-VIF. Signed-off-by: Chaitanya Tata <[email protected]>
Before proceeding with RPU bringup, do a sanity check by reading a known signature to make sure the Host-RPU comms are operational. Signed-off-by: Chaitanya Tata <[email protected]>
These are helpful for debugging RPU recovery only. Signed-off-by: Chaitanya Tata <[email protected]>
In order for the interface down to propagate and cleanup it needs more time, using Shell 10ms was working due to human delay, but programatically this needs higher delay. Signed-off-by: Chaitanya Tata <[email protected]>
RPU is only providing the per-wiphy (RPU) extended capabilities, so, remove storing of per-VIF extended capabilities. BTW, there is a memory leak here when doing interface down and up. Fixes SHEL-2738. Signed-off-by: Chaitanya Tata <[email protected]>
The extended capabilities are not freed causing a leak on interface down and up. Fixes SHEL-2738. Signed-off-by: Chaitanya Tata <[email protected]>
During recovery we might get further watchdog interrupts causing multiple recovery requests, ignore them if a recovery is already in progress. Signed-off-by: Chaitanya Tata <[email protected]>
This is to avoid successive recoveries in case we get successive watchdog interrupts from the RPU. Signed-off-by: Chaitanya Tata <[email protected]>
Check for RPU context as well. To fix this properly we need more fixes to be backported, but this should suffice for now. Signed-off-by: Chaitanya Tata <[email protected]>
In case RPU is stuck in consecutive recovery over a time period then that means it's not recoverable through RPU recovery, only thing left to do is to trigger a system reboot. This feature is disabled by default, so, either application can do their own implementatio or enable this feature in the driver along with configurable retries and window period. Signed-off-by: Chaitanya Tata <[email protected]>
Though this is no-op for now, it would lead to crash if BAL de-init is called which will be in the upcoming commits. Signed-off-by: Chaitanya Tata <[email protected]>
BAL de-init was never called, so, these weren't caught. In upcoming commits BAL de-init will be used, so, assign here to avoid crashes. Signed-off-by: Chaitanya Tata <[email protected]>
This can lead to crash in case driver initialization fails e.g. flashing wrong build (5340 on 7002) or if this API is called too early before the driver is initialized. Fixes SHEL-2576. Signed-off-by: Chaitanya Tata <[email protected]>
The QSPI dev context has it's own structure, so, need to be extract the QSPI dev ops from the context, this has been implemented improperly, but as it's not been used till date hadn't caused any problems. Signed-off-by: Chaitanya Tata <[email protected]>
Fix RPU recovery protection to solve build failures when RPU recovery is disabled. As recovery is primarily based on power-management, add a Kconfig dependency to enforce, this simplies the macros to protect the code. Signed-off-by: Chaitanya Tata <[email protected]>
During interface down in case TX has pending buffers in either TXQ or Pending_Q then they are not freed instead the Q itself is freed. Fix by traversing the Q and freeing all members. Signed-off-by: Chaitanya Tata <[email protected]>
This library should be used samples to manage Wi-Fi usage dynamically. Signed-off-by: Chaitanya Tata <[email protected]>
Use Wi-Fi ready library to manage Wi-Fi. Signed-off-by: Chaitanya Tata <[email protected]>
These are very frequent, so, a separate debug is added for debugging host RPU recovery logic. Signed-off-by: Chaitanya Tata <[email protected]>
This is useful to understand the reason for comms trigger b/w host and RPU. Signed-off-by: Chaitanya Tata <[email protected]>
Mention RPU recovery feature, there are no docs yet, so, no links. Signed-off-by: Chaitanya Tata <[email protected]>
With this offload, host doesn't need to manage RX buffers for management frames, and this saves Host-RPU comms and thus giving RPU to sleep more often and is essential to test RPU recovery. Signed-off-by: Chaitanya Tata <[email protected]>
github-actions
bot
added
doc-required
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
krish2718
requested review from
rlubos,
D-Triveni,
bama-nordic,
sachinthegreen,
rado17,
carlescufi and
tejlmand
as code owners
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
sachinthegreen
approved these changes
Aug 23, 2024
In crowded environments RPU is active for more than 10s due to too many retries and this triggers a false RPU recovery. To avoid this, increase the default to 50s to handle corner cases, as this will only impact the recovery triggered case, higher timeout doesn't have any impact in normal cases. Signed-off-by: Chaitanya Tata <[email protected]>
To handle interoperability issue with few APs, add a feature to keep sending keepalive frames periodically to avoid AP disconnecting the STA. This is disabled by default to avoid unnecessary power consumption as it's only seen with few old APs. Signed-off-by: Chaitanya Tata <[email protected]>
Pull latest fixes backported to 2.6 branch. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
pull_latest_wifi_fixes
branch
from
569d12a
to
6e8d788
Compare
udaynordic
approved these changes
Aug 28, 2024
bama-nordic
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.