nfc: Fix handling 0 size data in nfc_platform #13506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchat-nordic
requested review from
grochu,
anangl and
carlescufi
as code owners
github-actions
bot
added
the
doc-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
peknis
approved these changes
Dec 22, 2023
| @@ -650,7 +650,7 @@ Libraries for networking | |||
| Libraries for NFC | |||
| ----------------- | |||
|
|
|||
| |no_changes_yet_note| | |||
| * Fixed an issue with handling 0 size data in :file:`platform_internal_thread` file. | |||
There was a problem hiding this comment.
Suggested change
| * Fixed an issue with handling 0 size data in :file:`platform_internal_thread` file. | |
| * Fixed an issue with handling zero size data in the :file:`platform_internal_thread` file. |
dchat-nordic
force-pushed
the
nfc_data
branch
from
2d312ab
to
2d6e790
Compare
grochu
reviewed
Jan 4, 2024
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
maje-emb
reviewed
Jan 8, 2024
| struct nfc_item_header { | ||
| uint16_t ctx_size; | ||
| uint8_t ctx_size; |
There was a problem hiding this comment.
Shouldn't we add a range for config NFC_LIB_CTX_MAX_SIZE?
Fix handling data with 0 size when issuing a callback. Jira: NCSDK-25211 Signed-off-by: Dominik Chat <[email protected]>
maje-emb
approved these changes
Jan 9, 2024
grochu
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix handling data with 0 size when issuing a callback.
Jira: NCSDK-25211