Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: matter: update manifest and disable Read Client #13464

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

ArekBalysNordic
Copy link
Contributor

Disable Read Client functionality for all samples except Matter Light Switch and Matter Bridge App.
It added around 6 kB of free space in some samples.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 18, 2023

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@c84b2c4 nrfconnect/sdk-connectedhomeip@d95eb1d (master) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 18, 2023

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X

test-fw-nrfconnect-chip: added because there was no .github/test-spec.yml in 'matter'

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

Copy link
Contributor

@kkasperczyk-no kkasperczyk-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, I left some very minor comments, so feel free to ignore it, if not relevant.

samples/matter/light_switch/prj_no_dfu.conf Outdated Show resolved Hide resolved
@ArekBalysNordic ArekBalysNordic force-pushed the read_client_config branch 2 times, most recently from 8270bec to f9664a8 Compare December 19, 2023 09:58
Disable Read Client functionality for all samples except
Matter Light Switch and Matter Bridge App.
It added around 6 kB of free space in some samples.

Signed-off-by: Arkadiusz Balys <[email protected]>
@NordicBuilder NordicBuilder removed the DNM label Dec 19, 2023
@rlubos rlubos merged commit 2463ec9 into nrfconnect:main Dec 20, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval. manifest manifest-matter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants