Applications: nrf_desktop: Add subscriber event #13451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
KAGA164
force-pushed
the
nrf_desktop_subscriber_event
branch
from
73b51b5
to
653f75a
Compare
KAGA164
removed
doc-required
dchat-nordic
approved these changes
Dec 15, 2023
MarekPieta
requested changes
Dec 15, 2023
KAGA164
force-pushed
the
nrf_desktop_subscriber_event
branch
from
653f75a
to
8711087
Compare
github-actions
bot
added
the
doc-required
peknis
requested changes
Dec 18, 2023
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
KAGA164
force-pushed
the
nrf_desktop_subscriber_event
branch
from
8711087
to
eacf90a
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
peknis
approved these changes
Dec 18, 2023
MarekPieta
requested changes
Dec 19, 2023
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
| @@ -823,7 +823,9 @@ nRF Desktop event propagation | |||
| +-----------------------------------------------+-----------------------------------+ | | | | |||
| | :ref:`nrf_desktop_motion` | ``motion_event`` | | | | | |||
| +-----------------------------------------------+-----------------------------------+ | | | | |||
| | :ref:`nrf_desktop_usb_state` | ``usb_hid_event`` | | | | | |||
| | :ref:`nrf_desktop_hids` | ``hid_report_subscriber_event`` | | | | | |||
There was a problem hiding this comment.
Please align with the updated arrays that were generated by me locally using a script (to keep consistency): https://github.com/MarekPieta/fw-nrfconnect-nrf/tree/kaga_new_arrays
There was a problem hiding this comment.
Have you updated the arrays ?
KAGA164
force-pushed
the
nrf_desktop_subscriber_event
branch
2 times, most recently
from
10ed9a5
to
0d33db3
Compare
MarekPieta
requested changes
Dec 21, 2023
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
| uint8_t report_max; /**< Maximum number of reports with different ID, which can be | ||
| * processed. | ||
| */ | ||
| } params; /**< Subscriber parameters. Only needed when a subscriber is connecting. |
There was a problem hiding this comment.
I wonder if it wouldn't be better to fill the parameter in both cases or zero them (to avoid submitting event with garbage data)
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
| @@ -823,7 +823,9 @@ nRF Desktop event propagation | |||
| +-----------------------------------------------+-----------------------------------+ | | | | |||
| | :ref:`nrf_desktop_motion` | ``motion_event`` | | | | | |||
| +-----------------------------------------------+-----------------------------------+ | | | | |||
| | :ref:`nrf_desktop_usb_state` | ``usb_hid_event`` | | | | | |||
| | :ref:`nrf_desktop_hids` | ``hid_report_subscriber_event`` | | | | | |||
There was a problem hiding this comment.
Have you updated the arrays ?
This adds HIDs subscriber event which allows different transports with configurable prority and pipeline size subscibe to the HIDs reports. Jira: NCSDK-25088 Signed-off-by: Kamil Gawor <[email protected]>
KAGA164
force-pushed
the
nrf_desktop_subscriber_event
branch
from
0d33db3
to
7c91ad6
Compare
MarekPieta
approved these changes
Dec 21, 2023
Update information about events generated or processed by the given nrf_desktop modules. This updates also the application documentation. Jira: NCSDK-24644 Signed-off-by: Kamil Gawor <[email protected]>
Update changelog with new HID subscriber event in nRF Desktop application. Jira: NCSDK-24644 Signed-off-by: Kamil Gawor <[email protected]>
KAGA164
force-pushed
the
nrf_desktop_subscriber_event
branch
from
7c91ad6
to
7eb98df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new HID subscriber events which allows to connect different transports for HIDs report data.