samples: cellular: mss: Add support for provisioning library #13290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
glarsennordic
commented
Nov 30, 2023
glarsennordic
commented
Nov 30, 2023
samples/cellular/nrf_cloud_multi_service/src/cloud_connection.c
Outdated
Show resolved
Hide resolved
glarsennordic
force-pushed
the
IRIS7400
branch
from
7827475
to
2734e9f
Compare
jayteemo
reviewed
Nov 30, 2023
samples/cellular/nrf_cloud_multi_service/overlay-nrf_provisioning.conf
Outdated
Show resolved
Hide resolved
samples/cellular/nrf_cloud_multi_service/src/provisioning_support.c
Outdated
Show resolved
Hide resolved
samples/cellular/nrf_cloud_multi_service/src/provisioning_support.c
Outdated
Show resolved
Hide resolved
samples/cellular/nrf_cloud_multi_service/src/provisioning_support.c
Outdated
Show resolved
Hide resolved
glarsennordic
force-pushed
the
IRIS7400
branch
4 times, most recently
from
979532f
to
2319d94
Compare
glarsennordic
requested review from
plskeggs,
rlubos,
lemrey and
carlescufi
as code owners
|
Docs still need to be done, but the code is now (actually) ready for review. During rebase I had to make some changes to FOTA that I did not test, I am awaiting CI results for those. |
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
jayteemo
approved these changes
Dec 7, 2023
samples/cellular/nrf_cloud_multi_service/src/provisioning_support.c
Outdated
Show resolved
Hide resolved
samples/cellular/nrf_cloud_multi_service/src/provisioning_support.c
Outdated
Show resolved
Hide resolved
plskeggs
reviewed
Dec 12, 2023
|
I'm having a very hard time building docs locally, so I am force-pushing with some draft docs commits. No need to review them just yet. |
glarsennordic
force-pushed
the
IRIS7400
branch
from
72784f0
to
7c2fcd6
Compare
glarsennordic
force-pushed
the
IRIS7400
branch
from
7c2fcd6
to
889ac1c
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
peknis
requested changes
Dec 18, 2023
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
jayteemo
approved these changes
Dec 18, 2023
samples/cellular/nrf_cloud_multi_service/src/provisioning_support.c
Outdated
Show resolved
Hide resolved
glarsennordic
force-pushed
the
IRIS7400
branch
from
889ac1c
to
ebace3b
Compare
glarsennordic
force-pushed
the
IRIS7400
branch
from
ebace3b
to
f90fdb9
Compare
glarsennordic
force-pushed
the
IRIS7400
branch
from
f90fdb9
to
a4c4eda
Compare
|
Comments about the readme outside of the areas you already changed: This needs to be replaced with "@1.0.1": |
|
Ah, yep, good catch. I'll see that it is done, once I finish rebasing |
glarsennordic
force-pushed
the
IRIS7400
branch
3 times, most recently
from
824ef6b
to
cbf0850
Compare
plskeggs
reviewed
Dec 19, 2023
glarsennordic
force-pushed
the
IRIS7400
branch
from
cbf0850
to
49c095e
Compare
peknis
requested changes
Dec 20, 2023
| .. code-block:: console | ||
|
|
||
| west build --board *your_board* -p always -- -DCONFIG_NRF_CLOUD_PROVISION_CERTIFICATES=y -DCONFIG_NRF_CLOUD_CLIENT_ID_SRC_COMPILE_TIME=y "-DCONFIG_NRF_CLOUD_CLIENT_ID=\`"698d4c11-0ccc-4f04-89cd-6882724e3f6f\`"" | ||
|
|
||
| Configuring Wi-Fi access point credentials |
There was a problem hiding this comment.
Shouldn't this section go under the Configuration?
There was a problem hiding this comment.
I think it makes more sense in the building & running section since it specifically includes instructions on how to modify the build environment.
I mean, in some sense, all of the building & running sections are really just configuration sections that have elevated importance
glarsennordic
force-pushed
the
IRIS7400
branch
from
49c095e
to
9877e6e
Compare
glarsennordic
force-pushed
the
IRIS7400
branch
from
9877e6e
to
8c203c6
Compare
plskeggs
approved these changes
Dec 20, 2023
peknis
approved these changes
Dec 21, 2023
This commit adds a new Kconfig option, CONFIG_AT_HOST_STACK_SIZE so that the AT_HOST workqueue stack size can be customized. This commit also updates the configured iCONFIG_AT_HOST_STACK_SIZE and CONFIG_AT_MONITOR_HEAP_SIZE values for the nRF Cloud Multi Service Sample to 2048 bytes since nRF Cloud credentials sometimes exceed 1024 bytes. NCSDK-22966 Signed-off-by: Georges Oates_Larsen <[email protected]>
PDN_EVENT_NETWORK_DETACH is sometimes fired in lieu of PDN_EVENT_DEACTIVATED. Both should trigger `on_pdn_deactivated`, but currently only the latter does. This commit corrects that. Signed-off-by: Georges Oates_Larsen <[email protected]>
Sample reboot logic is now in a dedicated file (sample_reboot.c) so that it can be used in multiple places in the sample. Signed-off-by: Georges Oates_Larsen <[email protected]>
This commit adds support for the nrf_provisioning library to the nRF Cloud Multi Service Sample. IRIS-7400 Signed-off-by: Georges Oates_Larsen <[email protected]>
This commit reorganizes existing provisioning descriptions into a single top-level section. None of the contents have been changed, they are simple relocated. Content changes will be made in followup commits. Signed-off-by: Georges Oates_Larsen <[email protected]>
Update the MSS provisioning documentation to refer to Onboarding instead of Provisioning. Also update links and separate common instructions into smaller reusable sections. Also update onboarding instructions to all use more similar terminology. Signed-off-by: Georges Oates_Larsen <[email protected]>
Adds documentation for the recently added support for nRF Cloud Provisioning Services. Signed-off-by: Georges Oates_Larsen <[email protected]>
Console infills were previously misformatted, this commit corrects that. Signed-off-by: Georges Oates_Larsen <[email protected]>
At some point, the west util started requiring a slightly different format for board revision specifying on the command line. Update the sample's documentation to conform to this. Signed-off-by: Georges Oates_Larsen <[email protected]>
glarsennordic
force-pushed
the
IRIS7400
branch
from
8c203c6
to
2a978ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the provisioning library to the nRF Cloud Multi Service Sample.