-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: redistributing: use latest tag for Golioth #12551
doc: redistributing: use latest tag for Golioth #12551
Conversation
Thank you for your contribution! Note: This comment is automatically posted and updated by the Contribs GitHub Action. |
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me, but I'll let @gregersrygg give the approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wiba-nordic It looks fine to me, but I've never used Golioth. So it's probably better if someone with better knowledge of this can look at it.
From what I can tell, we use Golioth as an example on this page: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/nrf/releases_and_maturity/developing/ncs_distro.html#redistributing-the-ncs It is referenced as an example for providing a Zephyr module and for providing a west manifest. Since it's just the links that are changing here, I would assume we're good to accept this. |
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
This should not be marked as stale. Is there anything we need to do to get this merged? |
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Rebase needed |
Updated the links to the Golioth Zephyr SDK to use the latest v0.11.0 release. Signed-off-by: Mike Szczys <[email protected]>
f01b156
to
73bce81
Compare
@nordicjm thanks for the nudge. I've rebased and updated the tag number to match our latest release. |
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Updated the links to the Golioth Zephyr SDK to use the latest v0.11.0 release.