Skip to content
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.

Add ability to configure additional network interface names in image meta #214

Merged
merged 3 commits into from
Sep 15, 2021

Conversation

Mierdin
Copy link
Member

@Mierdin Mierdin commented Aug 18, 2021

The networkInterfaces field in the image metadata was created long ago, but currently does nothing. The idea at the time was to use this purely as a descriptive field, so that lesson authors could know which network interfaces to expect a given image to use.

However, Multus gives the ability to configure interface names when attaching pods to a network, so we can go beyond simply describing defaults - we can use this as a way of overriding those defaults, and set interface names at attachment time. This makes it possible to accommodate images that expect certain interface names, as described in nre-learning/nrelabs-curriculum#339

The field is now optional, but when present, will be used to specify the name of all interfaces following eth0, and will be consumed in order of the networks a pod is attached to.

@Mierdin Mierdin changed the title Add ability to configure additional network interface names in imag meta Add ability to configure additional network interface names in image meta Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #214 (3ab22c8) into master (ad4b25a) will increase coverage by 1.63%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   28.54%   30.17%   +1.63%     
==========================================
  Files          24       24              
  Lines        2032     2184     +152     
==========================================
+ Hits          580      659      +79     
- Misses       1402     1469      +67     
- Partials       50       56       +6     
Impacted Files Coverage Δ
db/ingestors/images.go 69.56% <66.66%> (+1.99%) ⬆️
scheduler/backends/kubernetes/pods.go 48.42% <76.92%> (+1.86%) ⬆️
config/config.go 74.00% <0.00%> (-1.56%) ⬇️
scheduler/backends/kubernetes/jobs.go 23.42% <0.00%> (-0.67%) ⬇️
scheduler/backends/kubernetes/kubernetes.go 15.85% <0.00%> (-0.50%) ⬇️
db/db.go 0.00% <0.00%> (ø)
api/exp/server.go 0.00% <0.00%> (ø)
services/utils.go 0.00% <0.00%> (ø)
api/exp/lessons.go 0.00% <0.00%> (ø)
api/exp/curricula.go 0.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4b25a...3ab22c8. Read the comment docs.

@hellt
Copy link

hellt commented Sep 15, 2021

Hi @Mierdin
do you want me to test this? Or is it not ready yet?

@Mierdin
Copy link
Member Author

Mierdin commented Sep 15, 2021

@hellt No, this should be okay, just needed to cross some Ts. I'll let you know in the curriculum discussion when you should be ready to open a PR.

@Mierdin Mierdin closed this Sep 15, 2021
@Mierdin Mierdin reopened this Sep 15, 2021
@Mierdin Mierdin merged commit ce01005 into master Sep 15, 2021
@Mierdin Mierdin deleted the network-interfaces branch September 15, 2021 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants