This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Add ability to configure additional network interface names in image meta #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
networkInterfaces
field in the image metadata was created long ago, but currently does nothing. The idea at the time was to use this purely as a descriptive field, so that lesson authors could know which network interfaces to expect a given image to use.However, Multus gives the ability to configure interface names when attaching pods to a network, so we can go beyond simply describing defaults - we can use this as a way of overriding those defaults, and set interface names at attachment time. This makes it possible to accommodate images that expect certain interface names, as described in nre-learning/nrelabs-curriculum#339
The field is now optional, but when present, will be used to specify the name of all interfaces following
eth0
, and will be consumed in order of the networks a pod is attached to.