refactor(api, application-generic): Encapsulate preference mutations in workflow use-cases #7005
+708
−413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@novu/client
@novu/framework
@novu/nextjs
@novu/headless
@novu/node
@novu/js
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
commit: |
rifont
commented
Nov 14, 2024
| @@ -40,7 +40,7 @@ export class Channels { | |||
| export class PreferencesDto { | |||
| @ValidateNested({ each: true }) | |||
| @Type(() => WorkflowPreference) | |||
| workflow: WorkflowPreference; | |||
| all: WorkflowPreference; | |||
There was a problem hiding this comment.
this was just completely wrong before.
rifont
commented
Nov 14, 2024
| organizationId: command.organizationId, | ||
| identifierOrInternalId: command.id, | ||
| }), | ||
| ); |
There was a problem hiding this comment.
Always use the GetWorkflow command at the end. Not the most performant, but the endpoint is infrequently used so it's a suitable compromise to avoid an even bigger refactor.
rifont
commented
Nov 14, 2024
| { | ||
| $set: updatePayload, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
The database mutation should happen before invalidating.
rifont
commented
Nov 14, 2024
| defaultPreferences: DEFAULT_WORKFLOW_PREFERENCES, | ||
| userPreferences: | ||
| body.preferenceSettings && | ||
| buildWorkflowPreferencesFromPreferenceChannels(body.critical ?? false, body.preferenceSettings), |
There was a problem hiding this comment.
Internally, all Workflow DTOs now carry a defaultPreferences and userPreferences object now.
preferenceSettings and critical are removed from all internal DTOs in preparation for their full removal.
rifont
commented
Nov 14, 2024
rifont
commented
Nov 14, 2024
…://github.com/novuhq/novu into nv-4752-start-writing-to-v2-preferences-for-all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
CreateWorkflow,UpdateWorkflow, andDeleteWorkflowuse-casesUpsertPreferencesuse-caseScreenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer