feat(dashboard,web): opt-in app switching and redirects #7002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChmaraX
commented
Nov 14, 2024
|
|
||
| useEffect(() => { | ||
| if (isLoaded && status !== NewDashboardOptInStatusEnum.OPTED_IN) { | ||
| window.location.href = '/legacy/workflows'; |
There was a problem hiding this comment.
using navigate() here won't work since its external url
ChmaraX
commented
Nov 14, 2024
| segment.track('New dashboard opt-in'); | ||
| updateUserOptInStatus(NewDashboardOptInStatusEnum.OPTED_IN); | ||
| await updateUserOptInStatus(NewDashboardOptInStatusEnum.OPTED_IN); | ||
| localStorage.setItem('mantine-theme', 'light'); |
There was a problem hiding this comment.
this needs to be set directly in local storage otherwise when using hook the operation seems to be async and can't be awaited
ChmaraX
commented
Nov 14, 2024
| * | ||
| * note: /legacy is part of public URL, so we can't navigate() outside of that | ||
| */ | ||
| window.location.href = window.location.origin; |
There was a problem hiding this comment.
for now we redirect to the default page which is the workflows page - otherwise we would need to parse old env id to new env slugs to redirect to env/<env_slug>/workflows - will do in separate PR if there is a hard requirement to keep env id
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?