fix(api, application-generic): Filter with supplied tags when fetching subscriber preferences
#6991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rifont
commented
Nov 13, 2024
Comment on lines
+72
to
+79
| await session.createTemplate({ | ||
| noFeedId: true, | ||
| tags: [marketingTag], | ||
| }); | ||
| await session.createTemplate({ | ||
| noFeedId: true, | ||
| tags: [], | ||
| }); |
There was a problem hiding this comment.
2 more workflows are creating to ensure the assertion accounts for both:
- workflows with mismatched tags
- workflows without tags
…ing-inbox-preferences
scopsy
approved these changes
Nov 13, 2024
…references' of ssh://github.com/novuhq/novu into nv-4750-tags-should-be-respected-when-filtering-inbox-preferences
rifont
deleted the
nv-4750-tags-should-be-respected-when-filtering-inbox-preferences
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
tagswhen fetching subscriber preferencesScreenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer