chore(dashboard): batch of small fixes #6977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
requested review from
SokratisVidros,
BiswaViraj,
ChmaraX and
desiprisg
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LetItRock
commented
Nov 12, 2024
| @@ -53,7 +53,7 @@ const MenuItem = ({ | |||
| <span className="text-xs">{children}</span> | |||
| {disabled && ( | |||
| <Badge kind="pill" variant="soft" className="ml-auto opacity-40"> | |||
| <BadgeContent variant="neutral">soon</BadgeContent> | |||
| <BadgeContent variant="neutral">coming soon</BadgeContent> | |||
There was a problem hiding this comment.
| @@ -67,6 +67,7 @@ export function ConfigureWorkflow() { | |||
| <FormField | |||
| control={control} | |||
| name="name" | |||
| defaultValue="" | |||
There was a problem hiding this comment.
fixes the react warning about changing input from uncontrolled to controlled
| @@ -235,7 +235,7 @@ export const AddNode = (_props: NodeProps<NodeType>) => { | |||
| } | |||
|
|
|||
| return ( | |||
| <div className="flex w-[300px] justify-center"> | |||
| <div className="flex w-[300px] cursor-pointer justify-center"> | |||
There was a problem hiding this comment.
add step button cursor pointer fix: https://linear.app/novu/issue/NV-4684/workflow-overview-two-in-one-react-flow-and-cursor-on-hover
| @@ -102,7 +102,7 @@ export const WorkflowList = () => { | |||
| ) : ( | |||
| <> | |||
| {workflowsQuery.data.workflows.map((workflow) => ( | |||
| <WorkflowRow workflow={workflow} /> | |||
| <WorkflowRow key={workflow._id} workflow={workflow} /> | |||
There was a problem hiding this comment.
react missing key warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
The batch of small improvements.
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer