feat(dashboard): page meta, gtm, and uptime #6974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
requested review from
SokratisVidros,
BiswaViraj,
ChmaraX and
desiprisg
LetItRock
commented
Nov 12, 2024
Comment on lines
+9
to
+11
| <link rel="icon" href="/favicon-gradient.svg" /> | ||
| <link rel="apple-touch-icon" href="/favicon-gradient.svg" /> | ||
| <link rel="manifest" href="/manifest.json" /> |
There was a problem hiding this comment.
favicons and manifest
Comment on lines
+22
to
+35
| <% if (env.VITE_GTM) { %> | ||
| <script> | ||
| (function (w, d, s, l, i) { | ||
| w[l] = w[l] || []; | ||
| w[l].push({ 'gtm.start': new Date().getTime(), event: 'gtm.js' }); | ||
| var f = d.getElementsByTagName(s)[0], | ||
| j = d.createElement(s), | ||
| dl = l != 'dataLayer' ? '&l=' + l : ''; | ||
| j.async = true; | ||
| j.src = 'https://www.googletagmanager.com/gtm.js?id=' + i + dl; | ||
| f.parentNode.insertBefore(j, f); | ||
| })(window, document, 'script', 'dataLayer', '<%= env.VITE_GTM %>'); | ||
| </script> | ||
| <% } %> |
Comment on lines
+47
to
+54
| <% } %> <% if (env.VITE_SELF_HOSTED === 'false' ) { %> | ||
| <script | ||
| src="https://uptime.betterstack.com/widgets/announcement.js" | ||
| data-id="144175" | ||
| async="async" | ||
| type="text/javascript" | ||
| ></script> | ||
| <% } %> |
| @@ -106,6 +106,7 @@ | |||
| "typescript": "5.6.2", | |||
| "typescript-eslint": "^8.0.1", | |||
| "vite": "^5.4.1", | |||
| "vite-plugin-ejs": "^1.7.0", | |||
There was a problem hiding this comment.
the Vite EJS plugin that allows the use of conditionals in the HTML template; by default, it's not supported by Vite :/
| content={field.value} | ||
| className="rounded-md rounded-s-none border-b-0 border-r-0 border-t-0 text-neutral-400" | ||
| <> | ||
| <PageMeta title={workflowName} /> |
There was a problem hiding this comment.
page meta component
SokratisVidros
approved these changes
Nov 12, 2024
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@novu/client
@novu/headless
@novu/framework
@novu/nest
@novu/js
@novu/nextjs
@novu/notification-center
@novu/node
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
@novu/stateless
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Favicon, Page meta, GTM, Better Stack Uptime
Screenshots
Screen.Recording.2024-11-12.at.16.58.19.mov