feat(dashboard): in-app editor unsaved changes modal plus handling esc and clicking on drawer gray overlay #6958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kflow name; textarea remove shadow
…c and clicking on drawer gray area
LetItRock
commented
Nov 12, 2024
| @@ -45,6 +45,7 @@ | |||
| "@radix-ui/react-switch": "^1.1.1", | |||
| "@radix-ui/react-tabs": "^1.1.1", | |||
| "@radix-ui/react-tooltip": "^1.1.3", | |||
| "@radix-ui/react-visually-hidden": "^1.1.0", | |||
There was a problem hiding this comment.
used to hide some required components, more about it in the comments below
| @@ -55,7 +55,7 @@ TabsTrigger.displayName = TabsPrimitive.Trigger.displayName; | |||
| const tabsContentVariants = cva('focus-visible:outline-none', { | |||
| variants: { | |||
| variant: { | |||
| default: 'ring-offset-background focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2', | |||
| default: '', | |||
There was a problem hiding this comment.
no need to show the outline on the tabs content component
| {/* TODO: show loading indicator */} | ||
| {workflow && step && stepType && <StepEditor workflow={workflow} step={step} stepType={stepType} />} | ||
| </motion.div> | ||
| <SheetContentBase asChild onInteractOutside={handleCloseSidebar} onEscapeKeyDown={handleCloseSidebar}> |
There was a problem hiding this comment.
The SheetContentBase is the component that allows to handle the clicks on the drawer overlay and ESC button clicks. But the thing is that it requires the use of the SheetTitle, SheetDescription under the hood, but the current implementation doesn't use it. So I had to hide these two visually.
We might decide to refactor that in the future.
There was a problem hiding this comment.
Please add a TODO in the code.
| </Tabs> | ||
| </form> | ||
| </Form> | ||
| <AlertDialog open={blocker.state === 'blocked'}> |
There was a problem hiding this comment.
The unsaved changes modal
desiprisg
approved these changes
Nov 12, 2024
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BiswaViraj
approved these changes
Nov 12, 2024
SokratisVidros
approved these changes
Nov 12, 2024
Base automatically changed from
nv-4513-workflow-editor-error-handling
to
next
November 12, 2024 16:43
@novu/client
@novu/headless
@novu/framework
@novu/js
@novu/nest
@novu/nextjs
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
@novu/stateless
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
In-App Editor Drawer:
Screenshots
Screen.Recording.2024-11-12.at.13.56.15.mov