feat(dashboard): Nv 4476 workflow editor header navigation #6700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BiswaViraj
changed the title
novu
@novu/client
@novu/framework
@novu/headless
@novu/nest
@novu/nextjs
@novu/js
@novu/node
@novu/notification-center
@novu/react
@novu/providers
@novu/react-native
@novu/shared
@novu/stateless
commit: |
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LetItRock
reviewed
Oct 16, 2024
SokratisVidros
approved these changes
Oct 16, 2024
| @@ -0,0 +1,96 @@ | |||
| import { cn } from '@/utils/ui'; | |||
There was a problem hiding this comment.
Nit picky comment: Is breadcrumb a primitive? It's a specific component displayed in one place in the app. Should we remove it from this folder?
There was a problem hiding this comment.
I guess we will use it in other areas too, like Activity feed, Subscribers list page
< Development / Subscribers / Biswajeet Das
|
|
||
| const BreadcrumbList = React.forwardRef<HTMLOListElement, React.ComponentPropsWithoutRef<'ol'>>( | ||
| ({ className, ...props }, ref) => ( | ||
| <ol |
LetItRock
approved these changes
Oct 17, 2024
Comment on lines
37
to
40
| { label: currentEnvironment?.name, href: '/' }, | ||
| { | ||
| label: 'Workflows', | ||
| href: workflowsRoute, |
There was a problem hiding this comment.
these two will be the same route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Screen.Recording.2024-10-16.at.4.33.37.PM.mov
Expand for optional sections
Related enterprise PR
Special notes for your reviewer