fix(js): Bypass cache during novu.notifications.list() #6690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LetItRock
reviewed
Oct 15, 2024
| return this.callWithSession(async () => { | ||
| const args = { limit, ...restOptions }; | ||
| try { | ||
| let data: ListNotificationsResponse | undefined = this.#useCache ? this.cache.getAll(args) : undefined; | ||
| let data: ListNotificationsResponse | undefined = | ||
| this.#useCache || useCache ? this.cache.getAll(args) : undefined; |
There was a problem hiding this comment.
@SokratisVidros, if I have set useCache: true in the options to the Novu class, then this function option useCache won't help with the override because the first part of or will be satisfied. Only when the options on the Novu class are use cache: false it will control it.
There was a problem hiding this comment.
🤦 good catch.It should be the other way around.
SokratisVidros
force-pushed
the
cache_false
branch
from
c95c76c
to
8ac468f
Compare
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
Introduce novu.notifications.list({ useCache: false }) option to always fetch the latest notifications and bypass the cache.
SokratisVidros
force-pushed
the
cache_false
branch
from
8ac468f
to
9d9de09
Compare
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
commit: |
LetItRock
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Introduce
novu.notifications.list({ useCache: true | false })option to always fetch the latest notifications and bypass the cache. This should give the ability to build an Inbox UI that auto-refreshes when a new notification is available.The
useCacheoption of the list function defaults to true.