bug(api): renamed

novuhq · Nov 14, 2024 · 864038e · 864038e
1 parent 580e0b1
commit 864038e
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 0 deletions.
diff --git a/.../src/app/workflows-v2/usecases/process-workflow-issues/process-workflow-issues.usecase.ts b/.../src/app/workflows-v2/usecases/process-workflow-issues/process-workflow-issues.usecase.ts
@@ -107,6 +107,7 @@ export class ProcessWorkflowIssuesUsecase {
     await this.addTriggerIdentifierNotUniqueIfApplicable(command, issues);
     this.addNameMissingIfApplicable(command, issues);
     this.addDescriptionTooLongIfApplicable(command, issues);
+    this.addTagsIssues(command, issues);
 
     return issues;
   }
@@ -179,4 +180,43 @@ export class ProcessWorkflowIssuesUsecase {
 
     return { ...workflow, issues };
   }
+  private addTagsIssues(
+    command: ProcessWorkflowIssuesCommand,
+    issues: Record<keyof WorkflowResponseDto, RuntimeIssue[]>
+  ) {
+    const tags = command.workflow.tags?.map((tag) => tag.trim());
+
+    if (!tags.length) {
+      return;
+    }
+
+    const tagsIssues: RuntimeIssue[] = [];
+
+    const duplicatedTags = tags.filter((tag, index) => tags.indexOf(tag) !== index);
+    const hasDuplications = duplicatedTags.length > 0;
+    if (hasDuplications) {
+      tagsIssues.push({
+        issueType: WorkflowIssueTypeEnum.DUPLICATED_VALUE,
+        message: `Duplicated tags: ${duplicatedTags.join(', ')}`,
+      });
+    }
+
+    const hasEmptyTags = tags?.some((tag) => !tag || tag === '');
+    if (hasEmptyTags) {
+      tagsIssues.push({ issueType: WorkflowIssueTypeEnum.MISSING_VALUE, message: 'Empty tag value' });
+    }
+
+    const exceedsMaxLength = tags?.some((tag) => tag.length > 8);
+    if (exceedsMaxLength) {
+      tagsIssues.push({
+        issueType: WorkflowIssueTypeEnum.LIMIT_REACHED,
+        message: 'Exceeded the 8 tag limit',
+      });
+    }
+
+    if (tagsIssues.length > 0) {
+      // eslint-disable-next-line no-param-reassign
+      issues.tags = tagsIssues;
+    }
+  }
 }
diff --git a/packages/shared/src/dto/workflows/workflow-response-dto.ts b/packages/shared/src/dto/workflows/workflow-response-dto.ts
@@ -26,4 +26,6 @@ export enum WorkflowIssueTypeEnum {
   MISSING_VALUE = 'MISSING_VALUE',
   MAX_LENGTH_ACCESSED = 'MAX_LENGTH_ACCESSED',
   WORKFLOW_ID_ALREADY_EXISTS = 'WORKFLOW_ID_ALREADY_EXISTS',
+  DUPLICATED_VALUE = 'DUPLICATED_VALUE',
+  LIMIT_REACHED = 'LIMIT_REACHED',
 }