Skip to content

Commit

Permalink
fix: add topics subscriber limit and tabs value info (#668)
Browse files Browse the repository at this point in the history
* fix: add topics subscriber limit and tabs value info

* fix: added back backend url and socketUrl
  • Loading branch information
jainpawan21 authored Sep 9, 2024
1 parent 022e727 commit 5e114f5
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 22 deletions.
10 changes: 6 additions & 4 deletions concepts/topics.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Users can also assign a name to a topic. This name doesn't need to be unique and

A topic would get assigned different subscribers that will receive a notification every time a notification is sent to the topic.

## Create A Topic
## Create a topic

In order to be able to send a notification to a topic, first the user needs to create one. It can be done like this:

Expand Down Expand Up @@ -42,7 +42,7 @@ const key = "unique-topic-identifier";
const result = await novu.topics.get(key);
```

## Rename a Topic
## Rename a topic

Descriptive name given during creation of topic can be changed later. This can be done like this:

Expand All @@ -61,7 +61,7 @@ This will return the whole Topic information, including the subscribers if havin

<Note>Topic Key can not be changed</Note>

## Add subscribers to a Topic
## Add subscribers to a topic

Adding subscribers to the topic is the main usecase of topic. A topic is like a group of subscribers. A notification can be sent to all subscribers of a topic at once

Expand Down Expand Up @@ -98,6 +98,8 @@ This call will return a response in the shape of:

The field `succeeded` will return the array of subscriber ids that have been correctly assigned to the topic. The field `failed` will show up only if there has been any subscriber that couldn't been assigned to the topic. This probably will happen if there is any typo in the given subscriberId or if the given subscriberId doesn't belong to the environment and the organization where the topic has been created.

<Info>One topic can have maximum 500K subscribers</Info>

### Create topic on the fly

To facilitate flows we allow to create a topic on the fly when adding subscribers.
Expand Down Expand Up @@ -130,7 +132,7 @@ const response = await novu.topics.getSubscriber(
without making extra calls to Novu.
</Note>

## Remove a subscriber from a Topic
## Remove a subscriber from a topic

A single or group of subscribers can be removed from an existing topic.

Expand Down
18 changes: 0 additions & 18 deletions inbox/react/get-started.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -53,24 +53,6 @@ Possible reasons for the Inbox not loading properly:

</Accordion>

<Accordion title="There is a render error due to the Inbox in React.">

The Inbox should be wrapped in `<Inbox>`

</Accordion>

<Accordion title="What is the difference between a redirect URL and CTA?">

The redirect URL is for the entire notification item, When the user clicks the notification, the user will be routed to that url. CTA are two call-to-action buttons. `onNotificationClick` function prop is used for redirecting url and the `onActionClick` function prop is used for CTA.

</Accordion>

<Accordion title="Can bell icon in Novu dashboard be used for in-app channel testing?">

Bell icon and Inbox in Novu dashboard is only for receiving system related notifications like user you invited has joined, password reset request sent. It can not to used to test Inbox. Consider using our [codesandbox example](https://codesandbox.io/s/kind-nova-xv6s9g?fontsize=14&hidenavigation=1&theme=dark) instead.

</Accordion>

<Accordion title="How to fix CORS error with Inbox?">
Our Inbox is configures for all hosts. Please disable root level `withCredentials` config in axios or fetch http requests.

Expand Down
2 changes: 2 additions & 0 deletions inbox/react/multiple-tabs.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,5 @@ function Novu() {
<Frame caption="Multiple Tabs in Inbox">
<img src="/images/inbox/client/react/multiple-tabs/multiple-tabs.png" />
</Frame>

<Info>Here tab value is taken from workflow tags. Tags can be configured in options field of [workflow](/sdks/framework/typescript/workflow).</Info>

0 comments on commit 5e114f5

Please sign in to comment.