Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Use root project identification and make proper options for install + shared/static libs #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

capnkenny
Copy link
Member

The issue found was that when using GLM via FetchContent_Declare, if different paths were specified in the call (i.e. src path, build path, etc). this would cause GLM to not properly install and would become invalid to projects attempting to use GLM in a non-header only fashion.

This PR accomplishes three things -

  1. This allows for determining if GLM is the root project or not.
  • If it is, it will cause GLM to produce a standalone install. This is the same behaviour master branch has today.
  • If not, it will only install if GLM_INSTALL is defined as ON. Similar to today's master branch, however it gives end-users the ability to still install the project.
  1. This allows for determining specifically if GLM will build as static or shared (or neither).

  2. This allows for the static/shared versions of GLM to be installed.

@capnkenny capnkenny requested a review from RubyNova June 10, 2022 18:08
@capnkenny
Copy link
Member Author

capnkenny commented Jun 10, 2022

Please do not merge until confirming with me? Looking into something for NovelRT's sake
UPDATE: Only merge if we want to require having GLM built as a static/shared library. If we are opting to go the header-only route, this is not required at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant