Fix missing change volume function

novelrt · Jul 29, 2024 · d85d52c · d85d52c
1 parent 71475be
commit d85d52c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 17 deletions.
diff --git a/include/NovelRT/Ecs/Audio/AudioSystem.h b/include/NovelRT/Ecs/Audio/AudioSystem.h
@@ -21,7 +21,7 @@ namespace NovelRT::Ecs::Audio
         NovelRT::Timing::Timestamp _systemTime;
         std::shared_ptr<PluginManagement::IResourceManagementPluginProvider> _resourceManagerPluginProvider;
 
-        // void ChangeAudioVolume(AudioEmitterComponent emitter, float desiredVolume);
+        void ChangeAudioVolume(AudioEmitterComponent emitter, float desiredVolume);
 
     public:
         AudioSystem(std::shared_ptr<PluginManagement::IResourceManagementPluginProvider> resourceManagerPluginProvider);

diff --git a/src/NovelRT/Ecs/Audio/AudioSystem.cpp b/src/NovelRT/Ecs/Audio/AudioSystem.cpp
@@ -221,26 +221,14 @@ namespace NovelRT::Ecs::Audio
             NovelRT::Utilities::Misc::Span<float>(asset.processedAudioFrames.data(), asset.processedAudioFrames.size()),
             asset.channelCount, asset.sampleRate);
         _soundCache.emplace(handle, asset);
-        // if (_mixer->IsLoaded(handle))
-        // {
-        //     _soundCache.insert({_counter, handle});
-        //     value = _counter;
         _counter++;
-        // }
         return handle;
     }
 
-    // void AudioSystem::ChangeAudioVolume(AudioEmitterComponent emitter, float desiredVolume)
-    // {
-    //     if (emitter.isMusic)
-    //     {
-    //         _mixer->SetMusicVolume(desiredVolume);
-    //     }
-    //     else
-    //     {
-    //         _mixer->SetSoundVolume(_soundCache.at(emitter.handle), desiredVolume);
-    //     }
-    // }
+    void AudioSystem::ChangeAudioVolume(AudioEmitterComponent emitter, float desiredVolume)
+    {
+        _mixer->SetSourceVolume(emitter.handle, desiredVolume);
+    }
 
     AudioSystem::~AudioSystem() noexcept
     {