-
Notifications
You must be signed in to change notification settings - Fork 89
Conversation
…1, fixes googlefonts/noto-fonts#1475
I found these differences (two of them look like positioning/collision issues, one I don't know). (... but maybe my old harfbuzz linked in fontdiff causes this :-() The text used is from https://github.com/googlefonts/noto-source/blob/main/test/Javanese/fontdiff-javanese.html The full PDF is here |
Thanks, both, this is very useful feedback! |
@dscorbett, I'll make it work for tolong, but ꦏ꧀ꦀ (C + pangkon + panyangga) is giving me a broken cluster in some Harfbuzz versions (but curiously not the latest ones). Unicode 14.0 says that an orthographic cluster is I'm working on all the other issues you mention. @marekjez86, the middle image is an improvement. The top and bottom ones look like problems. |
@marekjez86 - the positioning differences in your report are due to ufo2ft's order anchor attachment being unpredictable. They work for me; please check you are building with the latest ufo2ft. |
Indeed, <consonant, pangkon, panyangga> is probably unattested. I mentioned it anyway because it is graphically, if not phonetically, plausible, and because I don’t know enough about the script to be certain it is unattested. Sometimes scripts do surprising things. The analogous sequence is attested in Grantha, which is why this pattern is allowed in versions of HarfBuzz since harfbuzz/harfbuzz#3479. This is a HarfBuzz-specific speculative extension, so feel free to ignore it for this font. |
I'm happy to let this be usage driven. If someone tells me that their document with C+F+Z is broken, I'll fix it at a later date. |
I seem to have also busted cakra ligatures in the process... |
@marekjez86 I think this is good to go but please check those two anchor attachment issues you found again. |
This fixes various Javanese issues and allows the font to be built as a variable font. As I am not very familiar with building Javanese fonts and this includes a major change to the way that shaping is done, I would like some time for it to be tested before release.