always overwrite nonce #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you can pass a nonce in the params object and this lib will use it. If you don't it will mutate the params object by attaching a nonce.
However my retry mechanism passes the params object to this lib multiple times (in case of kraken API errors). And since this lib adds the nonce the first time, the second time this nonce gets reused resulting in "Invalid nonce" since it's using the same nonce it used the first time.
This hot fixes that, always overwriting the nonce property every call.
Better solution would be to not attach the nonce property to the params object passed from userland.
I was using this lib in my project called Gekko, but I will be using my fork until this is merged.