Skip to content

Commit

Permalink
chore: updated Notary v2 to Notary Project (#146)
Browse files Browse the repository at this point in the history
This chore PR resolves #127.

This PR also upgraded dependencies of the library.

---------

Signed-off-by: Patrick Zheng <[email protected]>
  • Loading branch information
Two-Hearts authored May 23, 2023
1 parent 0206650 commit a0cb09e
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
[![codecov](https://codecov.io/gh/notaryproject/notation-core-go/branch/main/graph/badge.svg)](https://codecov.io/gh/notaryproject/notation-core-go)
[![Go Reference](https://pkg.go.dev/badge/github.com/notaryproject/notation-core-go.svg)](https://pkg.go.dev/github.com/notaryproject/notation-core-go@main)

Contains support for Notary v2 signature envelope, and format specific implementation
Contains support for Notary Project signature envelope, and format specific implementation
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ go 1.19
require (
github.com/fxamacker/cbor/v2 v2.4.0
github.com/golang-jwt/jwt/v4 v4.5.0
github.com/veraison/go-cose v1.0.0
github.com/veraison/go-cose v1.1.0
golang.org/x/crypto v0.9.0
)

Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ github.com/fxamacker/cbor/v2 v2.4.0 h1:ri0ArlOR+5XunOP8CRUowT0pSJOwhW098ZCUyskZD
github.com/fxamacker/cbor/v2 v2.4.0/go.mod h1:TA1xS00nchWmaBnEIxPSE5oHLuJBAVvqrtAnWBwBCVo=
github.com/golang-jwt/jwt/v4 v4.5.0 h1:7cYmW1XlMY7h7ii7UhUyChSgS5wUJEnm9uZVTGqOWzg=
github.com/golang-jwt/jwt/v4 v4.5.0/go.mod h1:m21LjoU+eqJr34lmDMbreY2eSTRJ1cv77w39/MY0Ch0=
github.com/veraison/go-cose v1.0.0 h1:Jxirc0rl3gG7wUFgW+82tBQNeK8T8e2Bk1Vd298ob4A=
github.com/veraison/go-cose v1.0.0/go.mod h1:7ziE85vSq4ScFTg6wyoMXjucIGOf4JkFEZi/an96Ct4=
github.com/veraison/go-cose v1.1.0 h1:AalPS4VGiKavpAzIlBjrn7bhqXiXi4jbMYY/2+UC+4o=
github.com/veraison/go-cose v1.1.0/go.mod h1:7ziE85vSq4ScFTg6wyoMXjucIGOf4JkFEZi/an96Ct4=
github.com/x448/float16 v0.8.4 h1:qLwI1I70+NjRFUR3zs1JPUCgaCXSh3SW62uAKT1mSBM=
github.com/x448/float16 v0.8.4/go.mod h1:14CWIYCyZA/cWjXOioeEpHeN/83MdbZDRQHoFcYsOfg=
golang.org/x/crypto v0.9.0 h1:LF6fAI+IutBocDJ2OT0Q1g8plpYljMZ4+lty+dsqw3g=
Expand Down
2 changes: 1 addition & 1 deletion signature/jws/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ type jwsProtectedHeader struct {
// The "best by use" time for the artifact, as defined by the signer.
Expiry *time.Time `json:"io.cncf.notary.expiry,omitempty"`

// Specifies the Notary v2 Signing Scheme used by the signature.
// Specifies the Notary Project Signing Scheme used by the signature.
SigningScheme signature.SigningScheme `json:"io.cncf.notary.signingScheme"`

// The time at which the signature was generated. only valid when signing
Expand Down
4 changes: 2 additions & 2 deletions signature/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const (
// SignedAttributes represents signed metadata in the signature envelope.
// Reference: https://github.com/notaryproject/notaryproject/blob/main/signature-specification.md#signed-attributes
type SignedAttributes struct {
// SigningScheme defines the Notary v2 Signing Scheme used by the signature.
// SigningScheme defines the Notary Project Signing Scheme used by the signature.
SigningScheme SigningScheme

// SigningTime indicates the time at which the signature was generated.
Expand Down Expand Up @@ -86,7 +86,7 @@ type SignRequest struct {
// that produced the signature on behalf of the user.
SigningAgent string

// SigningScheme defines the Notary v2 Signing Scheme used by the signature.
// SigningScheme defines the Notary Project Signing Scheme used by the signature.
SigningScheme SigningScheme
}

Expand Down

0 comments on commit a0cb09e

Please sign in to comment.