Skip to content

Commit

Permalink
Standardize resource_type with pydantic models
Browse files Browse the repository at this point in the history 
Signed-off-by: Matt Daue <[email protected]>
  • Loading branch information
@mdaue
mdaue committed Mar 29, 2023
1 parent 6bf68b6 commit 93ca808
Show file tree
Hide file tree
Showing 5 changed files with 46 additions and 46 deletions.
10 changes: 5 additions & 5 deletions iambic/plugins/v0_1_0/aws/iam/group/utils.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ async def apply_group_managed_policies(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.ATTACH,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_arn,
attribute="managed_policies",
)
Expand Down Expand Up @@ -167,7 +167,7 @@ async def apply_group_managed_policies(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.DETACH,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_arn,
attribute="managed_policies",
)
Expand Down Expand Up @@ -214,7 +214,7 @@ async def apply_group_inline_policies(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.DELETE,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_name,
attribute="inline_policies",
)
Expand Down Expand Up @@ -257,7 +257,7 @@ async def apply_group_inline_policies(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.UPDATE,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_name,
attribute="inline_policies",
change_summary=policy_drift,
Expand All @@ -271,7 +271,7 @@ async def apply_group_inline_policies(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.CREATE,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_name,
attribute="inline_policies",
new_value=policy_document,
Expand Down
6 changes: 3 additions & 3 deletions iambic/plugins/v0_1_0/aws/iam/policy/utils.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ async def apply_update_managed_policy(
change_type=ProposedChangeType.UPDATE,
attribute="policy_document",
change_summary=policy_drift,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_arn,
current_value=existing_policy_document,
new_value=template_policy_document,
Expand Down Expand Up @@ -238,7 +238,7 @@ async def apply_managed_policy_tags(
ProposedChange(
change_type=ProposedChangeType.DETACH,
attribute="tags",
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_arn,
change_summary={"TagKeys": tags_to_remove},
)
Expand All @@ -260,7 +260,7 @@ async def apply_managed_policy_tags(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.ATTACH,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_arn,
attribute="tags",
new_value=tag,
Expand Down
26 changes: 13 additions & 13 deletions iambic/plugins/v0_1_0/aws/iam/role/utils.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ async def untag_role():
ProposedChange(
change_type=ProposedChangeType.DETACH,
attribute="tags",
resource_type="arn:aws:iam::aws:role",
resource_type="aws:iam:role",
resource_id=role_name,
change_summary={"TagKeys": tags_to_remove},
exceptions_seen=exceptions,
Expand All @@ -195,7 +195,7 @@ async def untag_role():
ProposedChange(
change_type=ProposedChangeType.DETACH,
attribute="tags",
resource_type="arn:aws:iam::aws:role",
resource_type="aws:iam:role",
resource_id=role_name,
change_summary={"TagKeys": tags_to_remove},
)
Expand Down Expand Up @@ -223,7 +223,7 @@ async def tag_role():
ProposedChange(
change_type=ProposedChangeType.ATTACH,
attribute="tags",
resource_type="arn:aws:iam::aws:role",
resource_type="aws:iam:role",
resource_id=role_name,
new_value=tag,
exceptions_seen=exceptions,
Expand All @@ -238,7 +238,7 @@ async def tag_role():
ProposedChange(
change_type=ProposedChangeType.ATTACH,
attribute="tags",
resource_type="arn:aws:iam::aws:role",
resource_type="aws:iam:role",
resource_id=role_name,
new_value=tag,
)
Expand Down Expand Up @@ -289,7 +289,7 @@ async def update_assume_role_policy(
ProposedChange(
change_type=ProposedChangeType.UPDATE,
attribute="assume_role_policy_document",
resource_type="arn:aws:iam::aws:role",
resource_type="aws:iam:role",
resource_id=role_name,
change_summary=policy_drift,
current_value=existing_policy_document,
Expand All @@ -301,7 +301,7 @@ async def update_assume_role_policy(
ProposedChange(
change_type=ProposedChangeType.CREATE,
attribute="assume_role_policy_document",
resource_type="arn:aws:iam::aws:role",
resource_type="aws:iam:role",
resource_id=role_name,
new_value=template_policy_document,
)
Expand Down Expand Up @@ -344,7 +344,7 @@ async def apply_role_managed_policies(
response.append(
ProposedChange(
change_type=ProposedChangeType.ATTACH,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_arn,
attribute="managed_policies",
)
Expand Down Expand Up @@ -373,7 +373,7 @@ async def apply_role_managed_policies(
response.append(
ProposedChange(
change_type=ProposedChangeType.DETACH,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_arn,
attribute="managed_policies",
)
Expand Down Expand Up @@ -423,7 +423,7 @@ async def apply_role_permission_boundary(
ProposedChange(
change_type=ProposedChangeType.ATTACH,
resource_id=template_boundary_policy_arn,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
attribute="permission_boundary",
)
]
Expand Down Expand Up @@ -456,7 +456,7 @@ async def apply_role_permission_boundary(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.DETACH,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=existing_boundary_policy_arn,
attribute="permission_boundary",
)
Expand Down Expand Up @@ -513,7 +513,7 @@ async def apply_role_inline_policies(
response.append(
ProposedChange(
change_type=ProposedChangeType.DELETE,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_name,
attribute="inline_policies",
)
Expand Down Expand Up @@ -554,7 +554,7 @@ async def apply_role_inline_policies(
response.append(
ProposedChange(
change_type=ProposedChangeType.UPDATE,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_name,
attribute="inline_policies",
change_summary=policy_drift,
Expand All @@ -568,7 +568,7 @@ async def apply_role_inline_policies(
response.append(
ProposedChange(
change_type=ProposedChangeType.CREATE,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_name,
attribute="inline_policies",
new_value=policy_document,
Expand Down
26 changes: 13 additions & 13 deletions iambic/plugins/v0_1_0/aws/iam/user/utils.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ async def apply_user_tags(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.DETACH,
resource_type="arn:aws:iam::aws:user",
resource_type="aws:iam:user",
resource_id=user_name,
attribute="tags",
change_summary={"TagKeys": tags_to_remove},
Expand All @@ -182,7 +182,7 @@ async def apply_user_tags(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.ATTACH,
resource_type="arn:aws:iam::aws:user",
resource_type="aws:iam:user",
resource_id=user_name,
attribute="tags",
new_value=tag,
Expand Down Expand Up @@ -230,7 +230,7 @@ async def apply_user_permission_boundary(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.ATTACH,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=template_boundary_policy_arn,
attribute="permission_boundary",
)
Expand Down Expand Up @@ -264,7 +264,7 @@ async def apply_user_permission_boundary(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.DETACH,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=existing_boundary_policy_arn,
attribute="permission_boundary",
)
Expand Down Expand Up @@ -321,7 +321,7 @@ async def apply_user_managed_policies(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.ATTACH,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_arn,
attribute="managed_policies",
)
Expand All @@ -342,7 +342,7 @@ async def apply_user_managed_policies(
[
ProposedChange(
change_type=ProposedChangeType.ATTACH,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_arn,
attribute="managed_policies",
)
Expand All @@ -365,7 +365,7 @@ async def apply_user_managed_policies(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.DETACH,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_arn,
attribute="managed_policies",
)
Expand All @@ -387,7 +387,7 @@ async def apply_user_managed_policies(
[
ProposedChange(
change_type=ProposedChangeType.DETACH,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_arn,
attribute="managed_policies",
)
Expand Down Expand Up @@ -431,7 +431,7 @@ async def apply_user_inline_policies(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.DELETE,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_name,
attribute="inline_policies",
)
Expand Down Expand Up @@ -475,7 +475,7 @@ async def apply_user_inline_policies(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.UPDATE,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_name,
attribute="inline_policies",
change_summary=policy_drift,
Expand All @@ -489,7 +489,7 @@ async def apply_user_inline_policies(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.CREATE,
resource_type="arn:aws:iam::aws:policy",
resource_type="aws:policy_document",
resource_id=policy_name,
attribute="inline_policies",
new_value=policy_document,
Expand Down Expand Up @@ -537,7 +537,7 @@ async def apply_user_groups(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.CREATE,
resource_type="arn:aws:iam::aws:group",
resource_type="aws:iam:group",
resource_id=group,
attribute="groups",
)
Expand All @@ -562,7 +562,7 @@ async def apply_user_groups(
proposed_changes = [
ProposedChange(
change_type=ProposedChangeType.DELETE,
resource_type="arn:aws:iam::aws:group",
resource_type="aws:iam:group",
resource_id=group,
attribute="groups",
)
Expand Down
Loading

0 comments on commit 93ca808

Please sign in to comment.