Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(substrate): add remote AWS signer #239

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

feat(substrate): add remote AWS signer #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
f4012ca
Use aws mod
lattejed Oct 18, 2022
b8f5e52
Add AWS signer init and trait bound
lattejed Oct 18, 2022
c5cfaae
Update dependencies
lattejed Oct 19, 2022
c49f832
Stub out AWS Pair
lattejed Oct 19, 2022
cfc4fc2
Stub out AWS pair impl
lattejed Oct 19, 2022
3d86880
Make FromAwsId async, Sized and Send
lattejed Oct 19, 2022
f1834c9
Make FromAwsId Sync
lattejed Oct 19, 2022
1bd2e3f
Add pubkey support
lattejed Oct 19, 2022
b70ed7c
Clean up lint errors
lattejed Oct 19, 2022
ef9115a
Add sync retrying remote signer with exponential backoff
lattejed Oct 20, 2022
0485593
Misc cleanup
lattejed Oct 20, 2022
a7138f8
Signer should include last error message when it panics
lattejed Oct 20, 2022
8e4e53c
Implement message signing
lattejed Oct 21, 2022
c7d43e8
Implement supertraits
lattejed Oct 21, 2022
98501dd
Bring naming in line with project conventions
lattejed Oct 24, 2022
5ca5afa
Implement error handling
lattejed Oct 24, 2022
c3caee7
Move signer settings to constants
lattejed Oct 24, 2022
79f5ea1
Improve docs
lattejed Oct 24, 2022
1702d65
Refactor sign_remote
lattejed Oct 24, 2022
871a0de
Prefer signing over singing
lattejed Oct 24, 2022
601d978
Implement missing supertrait
lattejed Oct 24, 2022
36110f8
Update test deps
lattejed Oct 26, 2022
61e7db9
Add AwsPairError
lattejed Oct 26, 2022
9bce695
Fix async issues and add sign test
lattejed Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions chains/nomad-substrate/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,16 @@ tracing-futures = "0.2.5"
thiserror = "1.0.30"
once_cell = "1.8.0"
primitive-types = { git = "https://github.com/paritytech/parity-common.git", branch = "master", features = ["serde"] }
rusoto_core = "0.48.0"
rusoto_kms = "0.48.0"

nomad-xyz-configuration = { path = "../../configuration" }
nomad-core = { path = "../../nomad-core" }
nomad-types = { path = "../../nomad-types" }

ethers-core = { git = "https://github.com/gakonst/ethers-rs", branch = "master" }
ethers-signers = { git = "https://github.com/gakonst/ethers-rs", branch = "master", features = ["aws"] }

[dev-dependencies]
rusoto_mock = "0.48.0"
base64 = "0.13.0"
Loading