Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: bootup db integrity check #228

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Aug 1, 2022

Motivation

Prevent agent from accidentally being run with different contract addresses that previous invocations. This will prevent manual config wrangling from accidentally triggering severe agent issues

Solution

Add a bootup integrity check. This check stores the core contract addresses in the DB, keyed by network, and checks the config addresses against the DB at each bootup.

TODO: figure out how to disable integrity check in tests 🤔

PR Checklist

  • Added Tests
  • Updated Documentation
  • Updated CHANGELOG.md for the appropriate package
  • Ran PR in local/dev/staging

@prestwich prestwich added enhancement New feature or request configuration labels Aug 1, 2022
@prestwich prestwich self-assigned this Aug 1, 2022
@prestwich prestwich marked this pull request as draft August 1, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant