This repository has been archived by the owner on May 28, 2022. It is now read-only.
updating Token Details for Launch #26
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-carroll
requested review from
kekonen,
luketchang,
prestwich and
yourbuddyconner
as code owners
anna-carroll
changed the title
anna-carroll
commented
Jan 10, 2022
|
|
||
| (async function main() { | ||
| const config = buildConfig("tokens") | ||
| // TODO: separate sheets for deployed tokens vs. updated tokens |
There was a problem hiding this comment.
@ltchang2019 need to propagate Deployed tokens to a different sheet than Updated tokens
anna-carroll
commented
Jan 10, 2022
| @@ -155,6 +155,7 @@ export class NomadContext extends MultiProvider { | |||
| if (!core) { | |||
| throw new Error(`Missing core for domain: ${nameOrDomain}`); | |||
| } | |||
| core.connect(this.mustGetProvider(nameOrDomain)); | |||
There was a problem hiding this comment.
@prestwich wdyt about this
|
@ltchang2019 do you have bandwidth to handle the final tick item -- writing a script to call |
Addressed by #31 (tested in dev) |
anna-carroll
force-pushed
the
anna/token-sheet
branch
from
d8b8eef
to
0c63903
Compare
|
@anna-carroll do we need to do anything here to merge and/or close this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setDetailsto SDKsetDetailsat launch