-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack #9
Webpack #9
Changes from all commits
825485c
830e25c
46d76e8
4abec43
1b1070d
52a69e3
7983d59
d5e6709
4d39c7e
6a39c14
505006a
cbdc5db
b3df26c
56f48f8
dd3a4b7
2c6164f
99558b5
8df24a5
dc3b655
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,6 @@ gh-pages/ | |
node_modules/ | ||
components/ | ||
bower_components/ | ||
/spec/*.js | ||
/spec/*.xml | ||
/spec/*.html |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,37 @@ | ||
language: node_js | ||
node_js: | ||
- '0.10' | ||
- '6' | ||
before_install: | ||
- wget https://s3-us-west-2.amazonaws.com/cdn.thegrid.io/caliper/libvips/libccv-0.1.1.tar.gz | ||
- mkdir $HOME/libccv | ||
- echo $HOME/libccv | ||
- tar -xvzf libccv-0.1.1.tar.gz -C $HOME/libccv | ||
before_script: | ||
- npm install -g grunt-cli | ||
after_success: | ||
- grunt gh-pages | ||
deploy: | ||
provider: script | ||
skip_cleanup: true | ||
script: grunt gh-pages | ||
on: | ||
tags: true | ||
repo: noflo/noflo-browser | ||
env: | ||
matrix: | ||
- CXX=g++-4.8 | ||
global: | ||
secure: mXwYeFfEjRsB31W5sorAjBXNPc2ZqV1IabgGv4fx8nmLGJ2KVCg7FRtJxPkshCxUMbn69S5JR12HcKWsFNY4uF0un7On70ggcq1+TpRFh8VkDr2KuRTsxW0NuZE3SO/xx7fxMQ98woHnW1FqLrQMhlZLDdW+OSVrx8/sJ4Xql3oZgt/n3VGaIQuJ6D9cvx/TT8WqxF+cEunm1T0eHpjtVTEKQHFDsOtztWJR/tHDrxpP0J8OrpEXtdFGXXbS8od4wCSJ0qmZXPfuD7cQgwwMLa3FnHxC5B4SOcjOagr8cr269BTSdV8CN5udVb8g2vuvF33T/Q7KFZKd/G9ue1w+7unyAG6MZT6cN3uzL5JwsAsU9C8fRF94yD7Q3dfkI+UMssf0kt3zfBU/XgvJJQ4mzoaouGcgdB2/jn0PbQrECUfILhG4/c7Y/6hQUjxJelc2hunXkY7QwOuRi4xNGsTgEZwBT7pZmPXRwOABZwdo/4WU6y4vTKINyX4f4di/bIOtewoTT+tYwab9A7xqka8SUTyc1FHuQyzAww9BK4TGjaWxKP7dYPmLdKWzGPUhEKwzsNBIKvB6g5vIULb6T7x4/UXOlI7hKnM1rUOpiYLto4RV4LJlIksUKpaC8z/dtmKko3qThXWNJc9tF6trCEUjV03xXfgAh1ohsV0/euVwYLk= | ||
addons: | ||
apt: | ||
sources: | ||
- ubuntu-toolchain-r-test | ||
packages: | ||
- libpng-dev | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same, all this crack introduced by libccv has to stay away. Cannot legitmately say to people that to build NoFlo you need all this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is not only noflo-ccv, but also noflo-image and noflo-canvas There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does not change the point. These dependencies are awful and should be completely uneccesary for a browser project. This will mean lots of people on Mac won't be able to build There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is all true. The right approach would be to fix it upstream in the modules with native dependencies:
But until that is done, I don't really see other options than either including these native deps on Travis, or removing those modules from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It should be noted that normal browser builds for NoFlo don't require these. Only projects that use those three modules. https://github.com/noflo/noflo-browser-app/blob/master/.travis.yml There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bergie At the very least, we got to file bugs on all the offending libraries so we can fix it later. If NPM is to be our solution for NoFlo on browser then we've got to find solutions for these kinds of issues. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe also have a tracking bug here which ties the general-problem together. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bergie what will be our recommendation to future libraries that need some (native) dependecies for Node.js and others/none for browser? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Filed here, #10 |
||
- libatlas-base-dev | ||
- libblas-dev | ||
- libcairo2-dev | ||
- libjpeg8-dev | ||
- libpango1.0-dev | ||
- libgif-dev | ||
- graphicsmagick | ||
- build-essential | ||
- g++-4.8 |
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nooo, what is this stuff? This is custom C++ libraries. Not cross-compiled for browser either. Not acceptable to include here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is, otherwise we can't install noflo-ccv via NPM, and hence expose its browser components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be super-happy to not need these native packages, but I wonder how to make NPM skip the deps that need them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So either