Merge pull request #151 from nodeset-org/remove-stats

Deprecate `service stats`

hyperdrive-cli/client/service.go

@@ -262,23 +262,6 @@ func (c *HyperdriveClient) PrintDaemonLogs(composeFiles []string, tail string, l
 	return printOutput(cmd)
 }
 
-// Print the Hyperdrive service stats
-func (c *HyperdriveClient) PrintServiceStats(composeFiles []string) error {
-	// Get service container IDs
-	cmd, err := c.compose(composeFiles, "ps -q")
-	if err != nil {
-		return err
-	}
-	containers, err := readOutput(cmd)
-	if err != nil {
-		return err
-	}
-	containerIds := strings.Split(strings.TrimSpace(string(containers)), "\n")
-
-	// Print stats
-	return printOutput(fmt.Sprintf("docker stats %s", strings.Join(containerIds, " ")))
-}
-
 // Print the Hyperdrive service compose config
 func (c *HyperdriveClient) PrintServiceCompose(composeFiles []string) error {
 	cmd, err := c.compose(composeFiles, "config")

hyperdrive-cli/commands/service/commands.go

@@ -231,13 +231,10 @@ func RegisterCommands(app *cli.App, name string, aliases []string) {
 			{
 				Name:    "stats",
 				Aliases: []string{"a"},
-				Usage:   "View the Hyperdrive service stats",
+				Usage:   "DEPRECATED - No longer supported",
 				Action: func(c *cli.Context) error {
-					// Validate args
-					utils.ValidateArgCount(c, 0)
-
 					// Run command
-					return serviceStats(c)
+					return serviceStats()
 				},
 			},
 

hyperdrive-cli/commands/service/stats.go

@@ -1,18 +1,11 @@
 package service
 
 import (
-	"github.com/nodeset-org/hyperdrive/hyperdrive-cli/client"
-	"github.com/urfave/cli/v2"
+	"fmt"
 )
 
 // View the Hyperdrive service stats
-func serviceStats(c *cli.Context) error {
-	// Get Hyperdrive client
-	hd, err := client.NewHyperdriveClientFromCtx(c)
-	if err != nil {
-		return err
-	}
-
-	// Print service stats
-	return hd.PrintServiceStats(getComposeFiles(c))
+func serviceStats() error {
+	fmt.Println("No longer supported - please run `docker stats -a` instead.")
+	return nil
 }

install/packages/debian/debian/changelog

@@ -1,3 +1,9 @@
+hyperdrive (1.1.0~b2) UNRELEASED; urgency=medium
+
+  * The `service stats` command has been deprecated; for people that wanted to track container stats, we recommend just running `docker stats -a` instead.
+
+ -- NodeSet Inc. <[email protected]>  Thu, 26 Sep 2024 20:23:47 +0000
+
 hyperdrive (1.1.0~b1) unstable; urgency=medium
 
   * Added the Constellation module. It can be accessed via the `hyperdrive cs` command.