Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm scripts #4311

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Update npm scripts #4311

merged 2 commits into from
Dec 21, 2021

Conversation

XhmikosR
Copy link
Contributor

  • enable caching for eslint and stylelint
  • double quote globs

Let me know about the cache location.

Unfortunately, remark does not seem to have a cache implementation and it seems it's the slowest of our lint scripts.

@nschonni
Copy link
Member

One approach i've seen is just to used the default location at the root, the action/cache can be used in CI to restore it

@XhmikosR
Copy link
Contributor Author

Do we want to use the cache on CI too? I usually don't use it on CI TBH, but happy to move it to the root folder.

Our main issue is still remark, but I have no idea what we can do since it doesn't have caching.

@Trott
Copy link
Member

Trott commented Dec 19, 2021

Our main issue is still remark, but I have no idea what we can do since it doesn't have caching.

It's not perfect, but over in nodejs/node, we have a timestamp file and our make task only lints what is newer than the timestamp file. That implementation uses some Makefile magic, but maybe we could do something similar.

Ref: https://github.com/nodejs/node/blob/23637e9a3b208892449268290143dad4391fee45/Makefile#L1257-L1276

@XhmikosR
Copy link
Contributor Author

Also, unifiedjs/unified-engine#22 which is what remark is using, in case anyone wants to work on it.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Dec 19, 2021

How about landing this as is and @nschonni or someone else improves it further later for CI and perhaps remark?

It should speed local development a lot, so that's a win.

@XhmikosR XhmikosR marked this pull request as ready for review December 20, 2021 07:56
@XhmikosR XhmikosR requested a review from a team as a code owner December 20, 2021 07:56
* enable caching for eslint and stylelint
* double quote globs
@Trott Trott enabled auto-merge (rebase) December 21, 2021 14:45
@Trott Trott merged commit e020da8 into main Dec 21, 2021
@Trott Trott deleted the XhmikosR-patch-5 branch December 21, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants