-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace uses of python distutils
library
#2888
Conversation
Please rebase this pull request so we can see if the tests pass. |
@cclauss done |
The CI test failures here will be fixed by #2908. |
#2908 is now merged so please rebase this PR so we can be sure that the tests pass. |
The rebase fixed the test failures on ubuntu and macos, but there are failures on Windows that are still happening. Windows didn't fail on the main branch, so I guess (but don't know) that those failures are related to the change in this PR. |
It is not available anymore in Python 3.12: https://peps.python.org/pep-0632/
Perhaps we need to |
Yes, you'll want to include |
https://github.com/nodejs/node-gyp/pull/2862/files The installation of |
But not because of
If you want Python to use utf-8 instead of the platform default encoding, set |
Attempting Edit: No luck. |
You've got a range of apparently unrelated test failures. There doesn't seem to be any Python output in the logs, so I guess someone who knows what those tests are doing will need to take a look. |
@brjsp It is with a heavy heart that I close your first contribution to node-gyp but I hope that this will not be your last contribution. You had the right solution and nodejs/gyp-next#201 contains the same fix. However, it was not simple as we needed to vendor in all of |
It is not available anymore in Python 3.12: https://peps.python.org/pep-0632/