Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint for test files #320

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ESLint for test files #320

wants to merge 2 commits into from

Commits on Oct 11, 2019

  1. Installed ESLint with recommended config for node 

    Installed ESLint and then used init to set it up. I had it use the
recommended settings, environment for node.
Fixes: nodejs#310
    @Glassig
    Glassig committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    130dc6d View commit details
    Browse the repository at this point in the history

  2. Fixed some ESLint errors in test files 

    I tried to lint the testfiles. Unfortunately, not all was easily
linted. I had problems with the test/fixtures/inspect-test.js file
and one variable in test/common.js. I am not familiar enough with
the tests and how they work to fix those errors.
    @Glassig
    Glassig committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    ec8dda8 View commit details
    Browse the repository at this point in the history