feat(jq): use id-based filtering to preserve original objects

internal/jq/jq.go

@@ -13,40 +13,42 @@ func Filter(filter string, n notifications.Notifications) (notifications.Notific
 		return n, nil
 	}
 
-	query, err := gojq.Parse(fmt.Sprintf(".[] | select(%s)", filter))
+	filteredIDs := []string{}
+
+	// The filter does only selection, not extraction.
+	query, err := gojq.Parse(fmt.Sprintf(".[] | select(%s) | .id", filter))
 	if err != nil {
 		panic(err)
 	}
 
-	// gojq works only on any data, so we need to convert Notifications to
-	// interface{}.
-	// This also gives us back the JSON fields from the API.
+	// gojq works only on `any` data, so we need to convert Notifications to
+	// interface{}. This also gives us back the JSON fields from the API.
 	notificationsRaw, err := n.ToInterface()
 	if err != nil {
 		return nil, err
 	}
 
-	fitleredNotificationsRaw := []interface{}{}
 	iter := query.Run(notificationsRaw)
 	for {
 		v, ok := iter.Next()
 		if !ok {
 			break
 		}
+
 		if err, ok := v.(error); ok {
 			if err, ok := err.(*gojq.HaltError); ok && err.Value() == nil {
 				break
 			}
-			panic(err)
+			return nil, err
 		}
 
-		fitleredNotificationsRaw = append(fitleredNotificationsRaw, v)
-	}
+		newId, ok := v.(string)
+		if !ok {
+			return nil, fmt.Errorf("invalid filtered id %#v", v)
+		}
 
-	filteredNotifications, err := notifications.FromInterface(fitleredNotificationsRaw)
-	if err != nil {
-		return nil, err
+		filteredIDs = append(filteredIDs, newId)
 	}
 
-	return filteredNotifications, nil
+	return n.FilterFromIds(filteredIDs), nil
 }