Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Android OpenSource license file #20

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Conversation

anatol
Copy link
Collaborator

@anatol anatol commented Mar 21, 2021

No description provided.

vendor/CMakeLists.txt Outdated Show resolved Hide resolved
@anatol
Copy link
Collaborator Author

anatol commented Mar 22, 2021

Yes it should be licenses. Rebased on the latest master. PTAL.

vendor/CMakeLists.txt Outdated Show resolved Hide resolved
@anatol
Copy link
Collaborator Author

anatol commented Mar 23, 2021

On a related note, could you please add a license for nmeum/android-tools project itself? So it can be installed to the same directory.

@nmeum
Copy link
Owner

nmeum commented Mar 23, 2021

On a related note, could you please add a license for nmeum/android-tools project itself? So it can be installed to the same directory.

Yes, I would like to do that. The problem is that the repository contains code written by different people (see the author metadata in the git format patches), my understanding is that adding a license retrospectively would require these people to agree with it. Not sure what would be the best approach to do that. Suggestions welcome.

@nmeum nmeum merged commit 2c13f03 into nmeum:master Mar 24, 2021
@anatol
Copy link
Collaborator Author

anatol commented Mar 25, 2021

Thanks for merging it.

As of relicencing - I do not really know, I am not a lawyer.

But I see 2 ways to interpret this situation:

  1. currently the android-tools cmake code is unlicensed i.e. there are no any agreement between the project owner (you) and the contributors. Anyone can do with these contributions anything they want, including relicensing.
  2. if you want to go a safer way you can create a ticket saying that you want to relicense the project and ask all contributors to give an agreement to relicense their changes. If some contributors did not provide the agreement then those changes need to be reimplemented/redone.

For the license type it would probably make sense to use the same as the Android upstream - Apache 2.

@nmeum
Copy link
Owner

nmeum commented Jun 2, 2021

Hm, the file has been removed in platform-tools-31.0.2 (see #30). Also: I think this is a bit more complicated in practice since not all bundled submodules are licensed under Apache-2.0. For instance, vendor/e2fsprogs is partially under GPLv2. Not sure what the proper way to proceed here is. We could attempt to install all NOTICE files found in ./vendor/**/NOTICE 🤔

@anatol anatol deleted the licenses branch June 28, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants