feat: updated tanstack router example #236
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
Someone is attempting to deploy a commit to a Personal Account owned by @nksaraf on Vercel. @nksaraf first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| routers: [ | ||
| { | ||
| name: "public", | ||
| type: "static", |
There was a problem hiding this comment.
i don't think this is correct, the new API is "type", "mode" is old, i think you will have to bump to vinxi": "0.3.9", and make it work with that
There was a problem hiding this comment.
Done, thanks. Should the validation schema not throw if it is being passed a wrong option tho? Or if it is for backwards compatibility reasons to at least print a deprecation warning.
There was a problem hiding this comment.
Yeah I think makes sense to do a deprecation warning, I just don't want to add those while we are still in 0.x.x versions, coz things are changing and can't add notices for everything, the validation should error (but I think for now we accepted both until I remove one) okay yeah maybe then a deprecation warning is a good idea, I think i will remove the option and just error in the validation)
There was a problem hiding this comment.
Great, yeah erroring sounds good to me
Hi there, was playing around with vinxi + tanstack and noticed the example was a bit out of date so just update it. In line with TanStack/router#1264. The CSS is a bit wacky and the project cannot be run within the Vinxi workspace as PNPM will try to link it with the local vinxi packages whichi use an experimental version of React and hence they cause the example to error out because it'd be use two different versions of React. Let me know if there is anything missing.