Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overrides): migrate pycairo to meson-python (and fix dependencies) #1800

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

jonathan-conder
Copy link
Contributor

Contribution checklist (recommended but not always applicable/required):

  • There's an automated test for this change
  • Commit messages or code include references to related issues or PRs (including third parties)
  • Commit messages are conventional - examples from the log include "feat: add changelog files to fixup hook", "fix(contourpy): allow wheel usage", and "test: add sqlalchemy2 test"

Explanation:

  • pycairo uses meson-python as of 1.27.0.
  • meson-python has basically always required meson and ninja. It also depends on pyproject-metadata but that seems to work without overrides.
  • pyproject-metadata uses flit-core as of 0.8.0.

@jonathan-conder
Copy link
Contributor Author

Turns out I accidentally added meson-python to my pyproject.toml - so the first 2 commits aren't needed to build pycairo. I'll leave them here for now though

@adisbladis
Copy link
Member

Turns out I accidentally added meson-python to my pyproject.toml - so the first 2 commits aren't needed to build pycairo. I'll leave them here for now though

What does this mean? That inputs are added despite not being needed?

@jonathan-conder
Copy link
Contributor Author

The inputs are needed if you have meson-python and/or pyproject-metadata in [tool.poetry.dependencies]. But they aren't needed if they only appear in [build-system].

So in hindsight, those commits should have been a separate PR.

@cpcloud cpcloud merged commit 3479bba into nix-community:master Sep 27, 2024
179 checks passed
@jonathan-conder jonathan-conder deleted the pycairo branch September 27, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants